From 0de4081d3b5689708136dd589d3554315e5ea6d1 Mon Sep 17 00:00:00 2001 From: Simon Howard Date: Fri, 27 Mar 2015 23:51:31 -0400 Subject: misc: Handle M_StringCopy() short buffer case. M_StringCopy() must always be provided a buffer of at least one character long, so that a NUL character can be written. If this is not the case, return immediately and indicate that the buffer was truncated. --- src/m_misc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/m_misc.c b/src/m_misc.c index ab3c7009..53b86dba 100644 --- a/src/m_misc.c +++ b/src/m_misc.c @@ -379,6 +379,11 @@ boolean M_StringCopy(char *dest, const char *src, size_t dest_size) dest[dest_size - 1] = '\0'; strncpy(dest, src, dest_size - 1); } + else + { + return false; + } + len = strlen(dest); return src[len] == '\0'; } -- cgit v1.2.3