From 9d01d090c48c74a29b4ef67e0cd204772a2193c3 Mon Sep 17 00:00:00 2001 From: Simon Howard Date: Fri, 24 Oct 2014 20:29:56 -0400 Subject: Replace strdup() with M_StringDuplicate(). strdup() can theoretically fail and return NULL. This could lead to a crash or undesirable behavior. Add M_StringDuplicate() which does the same thing but exits with an error if a string cannot be allocated. This fixes #456. Thanks to Quasar for the suggestion. --- HACKING | 1 + 1 file changed, 1 insertion(+) (limited to 'HACKING') diff --git a/HACKING b/HACKING index a7284ba5..3bbe23d0 100644 --- a/HACKING +++ b/HACKING @@ -130,6 +130,7 @@ avoided when writing code for Chocolate Doom. These are: strncpy() M_StringCopy() strcat() M_StringConcat() strncat() M_StringConcat() + strdup() M_StringDuplicate() Lots of the code includes calls to DEH_String() to simulate string replacement by the Dehacked tool. Be careful when using Dehacked -- cgit v1.2.3