From 8eb3200286d523379295143ce3f44d77ce036d4b Mon Sep 17 00:00:00 2001 From: Simon Howard Date: Tue, 1 Apr 2014 20:43:45 -0400 Subject: Replace all snprintf() calls with M_snprintf(). The Windows API has an _snprintf function that is not the same as Unix's snprintf(): if the string is truncated then no trailing NUL character is appended. This makes the function unsafe. Define a replacement/wrapper called M_snprintf that works the same but always appends a trailing NUL, for safety on Windows and other OSes that behave like this. Do the same thing for vsnprintf(), and update HACKING to list snprintf/vsnprintf as forbidden functions. This fixes #375; thanks to Quasar for pointing out the different behavior of these functions. --- src/hexen/p_setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/hexen/p_setup.c') diff --git a/src/hexen/p_setup.c b/src/hexen/p_setup.c index cd075651..181e19fe 100644 --- a/src/hexen/p_setup.c +++ b/src/hexen/p_setup.c @@ -700,7 +700,7 @@ void P_SetupLevel(int episode, int map, int playermask, skill_t skill) P_InitThinkers(); leveltime = 0; - snprintf(lumpname, sizeof(lumpname), "MAP%02d", map); + M_snprintf(lumpname, sizeof(lumpname), "MAP%02d", map); lumpnum = W_GetNumForName(lumpname); // // Begin processing map lumps -- cgit v1.2.3