From 8eb3200286d523379295143ce3f44d77ce036d4b Mon Sep 17 00:00:00 2001 From: Simon Howard Date: Tue, 1 Apr 2014 20:43:45 -0400 Subject: Replace all snprintf() calls with M_snprintf(). The Windows API has an _snprintf function that is not the same as Unix's snprintf(): if the string is truncated then no trailing NUL character is appended. This makes the function unsafe. Define a replacement/wrapper called M_snprintf that works the same but always appends a trailing NUL, for safety on Windows and other OSes that behave like this. Do the same thing for vsnprintf(), and update HACKING to list snprintf/vsnprintf as forbidden functions. This fixes #375; thanks to Quasar for pointing out the different behavior of these functions. --- src/hexen/sc_man.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/hexen/sc_man.c') diff --git a/src/hexen/sc_man.c b/src/hexen/sc_man.c index 35f5ec0b..bf3574c3 100644 --- a/src/hexen/sc_man.c +++ b/src/hexen/sc_man.c @@ -88,7 +88,7 @@ void SC_Open(char *name) if (sc_FileScripts == true) { - snprintf(fileName, sizeof(fileName), "%s%s.txt", sc_ScriptsDir, name); + M_snprintf(fileName, sizeof(fileName), "%s%s.txt", sc_ScriptsDir, name); SC_OpenFile(fileName); } else -- cgit v1.2.3