From 17c14e1fad6dc277a6e58e4f421d5c65e210d1fe Mon Sep 17 00:00:00 2001 From: Simon Howard Date: Tue, 1 Apr 2014 20:56:33 -0400 Subject: setup: Eliminate use of sprintf(). Use M_snprintf() or M_StringJoin() instead where appropriate. This fixes #371. --- src/setup/display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/setup/display.c') diff --git a/src/setup/display.c b/src/setup/display.c index 1c0f8ef4..da440fce 100644 --- a/src/setup/display.c +++ b/src/setup/display.c @@ -29,6 +29,7 @@ #include "textscreen.h" #include "m_config.h" +#include "m_misc.h" #include "mode.h" #include "display.h" @@ -152,8 +153,7 @@ void SetDisplayDriver(void) { char *env_string; - env_string = malloc(strlen(video_driver) + 30); - sprintf(env_string, "SDL_VIDEODRIVER=%s", video_driver); + env_string = M_StringJoin("SDL_VIDEODRIVER=", video_driver, NULL); putenv(env_string); free(env_string); } @@ -487,7 +487,7 @@ static void GenerateModesTable(TXT_UNCAST_ARG(widget), continue; } - sprintf(buf, "%ix%i", modes[i].w, modes[i].h); + M_snprintf(buf, sizeof(buf), "%ix%i", modes[i].w, modes[i].h); rbutton = TXT_NewRadioButton(buf, &vidmode, i); TXT_AddWidget(modes_table, rbutton); TXT_SignalConnect(rbutton, "selected", ModeSelected, &modes[i]); -- cgit v1.2.3