From 40cf697566a4df3f20cf5b0f1f03b111c7e0d0f2 Mon Sep 17 00:00:00 2001 From: notaz Date: Fri, 7 Dec 2012 02:16:18 +0200 Subject: configure: set float-abi even without armv6 --- configure | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/configure b/configure index 053dba9..e8e5b2a 100755 --- a/configure +++ b/configure @@ -215,16 +215,18 @@ if [ "$ARCH" = "arm" ]; then # automatically set mfpu and mfloat-abi if they are not set if [ "$have_arm_neon" = "yes" ]; then - echo "$CFLAGS" | grep -q -- '-mfpu=' || CFLAGS="$CFLAGS -mfpu=neon" - echo "$ASFLAGS" | grep -q -- '-mfpu=' || ASFLAGS="$ASFLAGS -mfpu=neon" + fpu="neon" elif [ "$have_armv6" = "yes" ]; then - echo "$CFLAGS" | grep -q -- '-mfpu=' || CFLAGS="$CFLAGS -mfpu=vfp" - echo "$ASFLAGS" | grep -q -- '-mfpu=' || ASFLAGS="$ASFLAGS -mfpu=vfp" + fpu="vfp" fi - floatabi_set_by_gcc=`$CC -v 2>&1 | grep -q -- --with-float= && echo yes` || true - if [ "$floatabi_set_by_gcc" != "yes" -a "$have_armv6" = "yes" ]; then - echo "$CFLAGS" | grep -q -- '-mfloat-abi=' || CFLAGS="$CFLAGS -mfloat-abi=softfp" - echo "$ASFLAGS" | grep -q -- '-mfloat-abi=' || ASFLAGS="$ASFLAGS -mfloat-abi=softfp" + if [ "x$fpu" != "x" ]; then + echo "$CFLAGS" | grep -q -- '-mfpu=' || CFLAGS="$CFLAGS -mfpu=$fpu" + echo "$ASFLAGS" | grep -q -- '-mfpu=' || ASFLAGS="$ASFLAGS -mfpu=$fpu" + floatabi_set_by_gcc=`$CC -v 2>&1 | grep -q -- --with-float= && echo yes` || true + if [ "$floatabi_set_by_gcc" != "yes" ]; then + echo "$CFLAGS" | grep -q -- '-mfloat-abi=' || CFLAGS="$CFLAGS -mfloat-abi=softfp" + echo "$ASFLAGS" | grep -q -- '-mfloat-abi=' || ASFLAGS="$ASFLAGS -mfloat-abi=softfp" + fi fi # must disable thumb as recompiler can't handle it -- cgit v1.2.3 From 8ad120c9c4dca424feac32098cb4af6a2c8f641f Mon Sep 17 00:00:00 2001 From: notaz Date: Sun, 9 Dec 2012 19:26:15 +0200 Subject: avoid bogus warning --- libpcsxcore/psxmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libpcsxcore/psxmem.c b/libpcsxcore/psxmem.c index db902b0..27663f1 100644 --- a/libpcsxcore/psxmem.c +++ b/libpcsxcore/psxmem.c @@ -55,7 +55,7 @@ void *psxMap(unsigned long addr, size_t size, int is_fixed, if (ret == MAP_FAILED) return NULL; - if (ret != req) + if (req != NULL && ret != req) SysMessage("psxMap: warning: wanted to map @%p, got %p\n", req, ret); -- cgit v1.2.3 From f29fbd5358e28135d389e2218da7c90f8b94b983 Mon Sep 17 00:00:00 2001 From: notaz Date: Sun, 9 Dec 2012 19:58:34 +0200 Subject: pipe error messages through single function for easier redirection to file, logcat or whatever --- frontend/libretro.c | 16 +++++++------- frontend/main.c | 46 +++++++++++++++++++-------------------- libpcsxcore/cdriso.c | 42 +++++++++++++++++------------------ libpcsxcore/new_dynarec/pcsxmem.c | 4 ++-- 4 files changed, 54 insertions(+), 54 deletions(-) diff --git a/frontend/libretro.c b/frontend/libretro.c index db13d7a..0eef059 100644 --- a/frontend/libretro.c +++ b/frontend/libretro.c @@ -236,7 +236,7 @@ bool retro_load_game(const struct retro_game_info *info) enum retro_pixel_format fmt = RETRO_PIXEL_FORMAT_RGB565; if (environ_cb(RETRO_ENVIRONMENT_SET_PIXEL_FORMAT, &fmt)) { native_rgb565 = 1; - fprintf(stderr, "RGB565 supported, using it\n"); + SysPrintf("RGB565 supported, using it\n"); } if (plugins_opened) { @@ -248,7 +248,7 @@ bool retro_load_game(const struct retro_game_info *info) /* have to reload after set_cd_image for correct cdr plugin */ if (LoadPlugins() == -1) { - printf("faled to load plugins\n"); + SysPrintf("failed to load plugins\n"); return false; } @@ -256,7 +256,7 @@ bool retro_load_game(const struct retro_game_info *info) NetOpened = 0; if (OpenPlugins() == -1) { - printf("faled to open plugins\n"); + SysPrintf("failed to open plugins\n"); return false; } @@ -264,14 +264,14 @@ bool retro_load_game(const struct retro_game_info *info) Config.PsxAuto = 1; if (CheckCdrom() == -1) { - printf("unsupported/invalid CD image: %s\n", info->path); + SysPrintf("unsupported/invalid CD image: %s\n", info->path); return false; } SysReset(); if (LoadCdrom() == -1) { - printf("could not load CD-ROM!\n"); + SysPrintf("could not load CD-ROM!\n"); return false; } emu_on_new_cd(0); @@ -359,7 +359,7 @@ void retro_init(void) ret = emu_core_preinit(); ret |= emu_core_init(); if (ret != 0) { - printf("PCSX init failed, sorry\n"); + SysPrintf("PCSX init failed.\n"); exit(1); } @@ -379,11 +379,11 @@ void retro_init(void) } } if (f != NULL) { - printf("found BIOS file: %s\n", Config.Bios); + SysPrintf("found BIOS file: %s\n", Config.Bios); fclose(f); } else - printf("no BIOS files found.\n"); + SysPrintf("no BIOS files found.\n"); level = 1; environ_cb(RETRO_ENVIRONMENT_SET_PERFORMANCE_LEVEL, &level); diff --git a/frontend/main.c b/frontend/main.c index 59b68d5..762d753 100644 --- a/frontend/main.c +++ b/frontend/main.c @@ -187,7 +187,7 @@ static void check_memcards(void) f = fopen(buf, "rb"); if (f == NULL) { - printf("Creating memcard: %s\n", buf); + SysPrintf("Creating memcard: %s\n", buf); CreateMcd(buf); } else @@ -228,7 +228,7 @@ do_state_slot: snprintf(hud_msg, sizeof(hud_msg), "STATE SLOT %d [%s]", state_slot, emu_check_state(state_slot) == 0 ? "USED" : "FREE"); hud_new_msg = 3; - printf("* %s\n", hud_msg); + SysPrintf("* %s\n", hud_msg); break; case SACTION_TOGGLE_FSKIP: pl_rearmed_cbs.fskip_advice = 0; @@ -301,7 +301,7 @@ do_state_slot: if (GPU_open != NULL) { ret = GPU_open(&gpuDisp, "PCSX", NULL); if (ret) - fprintf(stderr, "GPU_open returned %d\n", ret); + SysMessage("GPU_open returned %d", ret); } return; #endif @@ -348,7 +348,7 @@ static void parse_cwcheat(void) if (feof(f)) goto out; - printf("cwcheat section found for %s\n", CdromId); + SysPrintf("cwcheat section found for %s\n", CdromId); while (fgets(line, sizeof(line), f)) { p = line + strlen(line); @@ -360,12 +360,12 @@ static void parse_cwcheat(void) if (strncmp(line, "_S", 2) == 0) break; if (strncmp(line, "_G", 2) == 0) { - printf(" cwcheat game name: '%s'\n", line + 3); + SysPrintf(" cwcheat game name: '%s'\n", line + 3); continue; } if (strncmp(line, "_C0", 3) == 0) { if (!newcheat && Cheats[NumCheats - 1].n == 0) { - printf("cheat '%s' failed to parse\n", name); + SysPrintf("cheat '%s' failed to parse\n", name); free(Cheats[NumCheats - 1].Descr); NumCheats--; } @@ -374,7 +374,7 @@ static void parse_cwcheat(void) continue; } if (sscanf(line, "_L %x %x", &a, &v) != 2) { - printf("line failed to parse: '%s'\n", line); + SysPrintf("line failed to parse: '%s'\n", line); continue; } @@ -418,8 +418,8 @@ void emu_on_new_cd(int show_hud_msg) parse_cwcheat(); if (Config.HLE) { - printf("note: running with HLE BIOS, expect compatibility problems\n"); - printf("----------------------------------------------------------\n"); + SysPrintf("note: running with HLE BIOS, expect compatibility problems\n"); + SysPrintf("----------------------------------------------------------\n"); } if (show_hud_msg) { @@ -452,7 +452,7 @@ int emu_core_init(void) check_memcards(); if (EmuInit() == -1) { - printf("PSX emulator couldn't be initialized.\n"); + SysPrintf("PSX emulator couldn't be initialized.\n"); return -1; } @@ -485,7 +485,7 @@ int main(int argc, char *argv[]) else if (!strcmp(argv[i], "-cfg")) { if (i+1 >= argc) break; strncpy(cfgfile_basename, argv[++i], MAXPATHLEN-100); /* TODO buffer overruns */ - printf("Using config file %s.\n", cfgfile_basename); + SysPrintf("Using config file %s.\n", cfgfile_basename); } else if (!strcmp(argv[i], "-cdfile")) { char isofilename[MAXPATHLEN]; @@ -578,7 +578,7 @@ int main(int argc, char *argv[]) if (cdfile) { if (LoadCdrom() == -1) { ClosePlugins(); - printf(_("Could not load CD-ROM!\n")); + SysPrintf(_("Could not load CD-ROM!\n")); return -1; } emu_on_new_cd(!loadst); @@ -588,7 +588,8 @@ int main(int argc, char *argv[]) if (loadst_f) { int ret = LoadState(loadst_f); - printf("%s state file: %s\n", ret ? "failed to load" : "loaded", loadst_f); + SysPrintf("%s state file: %s\n", + ret ? "failed to load" : "loaded", loadst_f); ready_to_go |= ret == 0; } @@ -598,7 +599,8 @@ int main(int argc, char *argv[]) // If a state has been specified, then load that if (loadst) { int ret = emu_load_state(loadst - 1); - printf("%s state %d\n", ret ? "failed to load" : "loaded", loadst); + SysPrintf("%s state %d\n", + ret ? "failed to load" : "loaded", loadst); } } else @@ -732,7 +734,8 @@ int emu_save_state(int slot) #ifndef __ARM_ARCH_7A__ /* XXX */ sync(); #endif - printf("* %s \"%s\" [%d]\n", ret == 0 ? "saved" : "failed to save", fname, slot); + SysPrintf("* %s \"%s\" [%d]\n", + ret == 0 ? "saved" : "failed to save", fname, slot); return ret; } @@ -752,13 +755,10 @@ int emu_load_state(int slot) void SysPrintf(const char *fmt, ...) { va_list list; - char msg[512]; va_start(list, fmt); - vsprintf(msg, fmt, list); + vfprintf(emuLog, fmt, list); va_end(list); - - fprintf(emuLog, "%s", msg); } void SysMessage(const char *fmt, ...) { @@ -766,13 +766,13 @@ void SysMessage(const char *fmt, ...) { char msg[512]; va_start(list, fmt); - vsprintf(msg, fmt, list); + vsnprintf(msg, sizeof(msg), fmt, list); va_end(list); if (msg[strlen(msg) - 1] == '\n') msg[strlen(msg) - 1] = 0; - fprintf(stderr, "%s\n", msg); + SysPrintf("%s\n", msg); } static void SignalExit(int sig) { @@ -917,7 +917,7 @@ void *SysLoadLibrary(const char *lib) { void *ret; int i; - printf("plugin: %s\n", lib); + SysPrintf("plugin: %s\n", lib); if (tmp != NULL) { tmp++; @@ -928,7 +928,7 @@ void *SysLoadLibrary(const char *lib) { ret = dlopen(lib, RTLD_NOW); if (ret == NULL) - fprintf(stderr, "dlopen: %s\n", dlerror()); + SysMessage("dlopen: %s", dlerror()); return ret; } diff --git a/libpcsxcore/cdriso.c b/libpcsxcore/cdriso.c index c9d94f2..28bb3df 100644 --- a/libpcsxcore/cdriso.c +++ b/libpcsxcore/cdriso.c @@ -741,13 +741,13 @@ static int handlepbp(const char *isofile) { ret = fread(&pbp_hdr, 1, sizeof(pbp_hdr), cdHandle); if (ret != sizeof(pbp_hdr)) { - fprintf(stderr, "failed to read pbp\n"); + SysPrintf("failed to read pbp\n"); goto fail_io; } ret = fseek(cdHandle, pbp_hdr.psar_offs, SEEK_SET); if (ret != 0) { - fprintf(stderr, "failed to seek to %x\n", pbp_hdr.psar_offs); + SysPrintf("failed to seek to %x\n", pbp_hdr.psar_offs); goto fail_io; } @@ -758,12 +758,12 @@ static int handlepbp(const char *isofile) { // multidisk image? ret = fseek(cdHandle, pbp_hdr.psar_offs + 0x200, SEEK_SET); if (ret != 0) { - fprintf(stderr, "failed to seek to %x\n", pbp_hdr.psar_offs + 0x200); + SysPrintf("failed to seek to %x\n", pbp_hdr.psar_offs + 0x200); goto fail_io; } if (fread(&offsettab, 1, sizeof(offsettab), cdHandle) != sizeof(offsettab)) { - fprintf(stderr, "failed to read offsettab\n"); + SysPrintf("failed to read offsettab\n"); goto fail_io; } @@ -773,7 +773,7 @@ static int handlepbp(const char *isofile) { } cdrIsoMultidiskCount = i; if (cdrIsoMultidiskCount == 0) { - fprintf(stderr, "multidisk eboot has 0 images?\n"); + SysPrintf("multidisk eboot has 0 images?\n"); goto fail_io; } @@ -784,7 +784,7 @@ static int handlepbp(const char *isofile) { ret = fseek(cdHandle, psisoimg_offs, SEEK_SET); if (ret != 0) { - fprintf(stderr, "failed to seek to %x\n", psisoimg_offs); + SysPrintf("failed to seek to %x\n", psisoimg_offs); goto fail_io; } @@ -793,14 +793,14 @@ static int handlepbp(const char *isofile) { } if (strcmp(psar_sig, "PSISOIMG00") != 0) { - fprintf(stderr, "bad psar_sig: %s\n", psar_sig); + SysPrintf("bad psar_sig: %s\n", psar_sig); goto fail_io; } // seek to TOC ret = fseek(cdHandle, psisoimg_offs + 0x800, SEEK_SET); if (ret != 0) { - fprintf(stderr, "failed to seek to %x\n", psisoimg_offs + 0x800); + SysPrintf("failed to seek to %x\n", psisoimg_offs + 0x800); goto fail_io; } @@ -835,7 +835,7 @@ static int handlepbp(const char *isofile) { // seek to ISO index ret = fseek(cdHandle, psisoimg_offs + 0x4000, SEEK_SET); if (ret != 0) { - fprintf(stderr, "failed to seek to ISO index\n"); + SysPrintf("failed to seek to ISO index\n"); goto fail_io; } @@ -855,7 +855,7 @@ static int handlepbp(const char *isofile) { for (i = 0; i < compr_img->index_len; i++) { ret = fread(&index_entry, 1, sizeof(index_entry), cdHandle); if (ret != sizeof(index_entry)) { - fprintf(stderr, "failed to read index_entry #%d\n", i); + SysPrintf("failed to read index_entry #%d\n", i); goto fail_index; } @@ -901,18 +901,18 @@ static int handlecbin(const char *isofile) { ret = fread(&ciso_hdr, 1, sizeof(ciso_hdr), cdHandle); if (ret != sizeof(ciso_hdr)) { - fprintf(stderr, "failed to read ciso header\n"); + SysPrintf("failed to read ciso header\n"); return -1; } if (strncmp(ciso_hdr.magic, "CISO", 4) != 0 || ciso_hdr.total_bytes <= 0 || ciso_hdr.block_size <= 0) { - fprintf(stderr, "bad ciso header\n"); + SysPrintf("bad ciso header\n"); return -1; } if (ciso_hdr.header_size != 0 && ciso_hdr.header_size != sizeof(ciso_hdr)) { ret = fseek(cdHandle, ciso_hdr.header_size, SEEK_SET); if (ret != 0) { - fprintf(stderr, "failed to seek to %x\n", ciso_hdr.header_size); + SysPrintf("failed to seek to %x\n", ciso_hdr.header_size); return -1; } } @@ -931,7 +931,7 @@ static int handlecbin(const char *isofile) { ret = fread(compr_img->index_table, sizeof(compr_img->index_table[0]), compr_img->index_len, cdHandle); if (ret != compr_img->index_len) { - fprintf(stderr, "failed to read index table\n"); + SysPrintf("failed to read index table\n"); goto fail_index; } @@ -942,7 +942,7 @@ static int handlecbin(const char *isofile) { compr_img->index_table[i] = (index << ciso_hdr.align) | plain; } if ((long long)index << ciso_hdr.align >= 0x80000000ll) - fprintf(stderr, "warning: ciso img too large, expect problems\n"); + SysPrintf("warning: ciso img too large, expect problems\n"); return 0; @@ -1064,13 +1064,13 @@ static int cdread_compressed(FILE *f, void *dest, int sector, int offset) } if (sector >= compr_img->index_len * 16) { - fprintf(stderr, "sector %d is past img end\n", sector); + SysPrintf("sector %d is past img end\n", sector); return -1; } start_byte = compr_img->index_table[block] & 0x7fffffff; if (fseek(cdHandle, start_byte, SEEK_SET) != 0) { - fprintf(stderr, "seek error for block %d at %x: ", + SysPrintf("seek error for block %d at %x: ", block, start_byte); perror(NULL); return -1; @@ -1079,13 +1079,13 @@ static int cdread_compressed(FILE *f, void *dest, int sector, int offset) is_compressed = !(compr_img->index_table[block] & 0x80000000); size = (compr_img->index_table[block + 1] & 0x7fffffff) - start_byte; if (size > sizeof(compr_img->buff_compressed)) { - fprintf(stderr, "block %d is too large: %u\n", block, size); + SysPrintf("block %d is too large: %u\n", block, size); return -1; } if (fread(is_compressed ? compr_img->buff_compressed : compr_img->buff_raw[0], 1, size, cdHandle) != size) { - fprintf(stderr, "read error for block %d at %x: ", block, start_byte); + SysPrintf("read error for block %d at %x: ", block, start_byte); perror(NULL); return -1; } @@ -1095,12 +1095,12 @@ static int cdread_compressed(FILE *f, void *dest, int sector, int offset) cdbuffer_size = cdbuffer_size_expect; ret = uncompress2(compr_img->buff_raw[0], &cdbuffer_size, compr_img->buff_compressed, size); if (ret != 0) { - fprintf(stderr, "uncompress failed with %d for block %d, sector %d\n", + SysPrintf("uncompress failed with %d for block %d, sector %d\n", ret, block, sector); return -1; } if (cdbuffer_size != cdbuffer_size_expect) - fprintf(stderr, "cdbuffer_size: %lu != %lu, sector %d\n", cdbuffer_size, + SysPrintf("cdbuffer_size: %lu != %lu, sector %d\n", cdbuffer_size, cdbuffer_size_expect, sector); } diff --git a/libpcsxcore/new_dynarec/pcsxmem.c b/libpcsxcore/new_dynarec/pcsxmem.c index 88e8112..90f7765 100644 --- a/libpcsxcore/new_dynarec/pcsxmem.c +++ b/libpcsxcore/new_dynarec/pcsxmem.c @@ -34,7 +34,7 @@ static void map_item(u32 *out, const void *h, u32 flag) { u32 hv = (u32)h; if (hv & 1) { - fprintf(stderr, "FATAL: %p has LSB set\n", h); + SysPrintf("FATAL: %p has LSB set\n", h); abort(); } *out = (hv >> 1) | (flag << 31); @@ -303,7 +303,7 @@ void new_dyna_pcsx_mem_init(void) // have to map these further to keep tcache close to .text mem_readtab = psxMap(0x08000000, 0x200000 * 4, 0, MAP_TAG_LUTS); if (mem_readtab == NULL) { - fprintf(stderr, "failed to map mem tables\n"); + SysPrintf("failed to map mem tables\n"); exit(1); } mem_writetab = mem_readtab + 0x100000; -- cgit v1.2.3 From f9f60dae01fe8a8262d52950893c2674c4545f4a Mon Sep 17 00:00:00 2001 From: Toad King Date: Sun, 2 Dec 2012 14:36:18 -0500 Subject: libretro: use SRAM saving routines for memory card. force only one memory card for libretro --- frontend/libretro.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/frontend/libretro.c b/frontend/libretro.c index db13d7a..15041bc 100644 --- a/frontend/libretro.c +++ b/frontend/libretro.c @@ -32,6 +32,10 @@ static int samples_sent, samples_to_send; static int plugins_opened; static int native_rgb565; +/* memory card data */ +extern char Mcd1Data[MCD_SIZE]; +extern char McdDisable[2]; + /* PCSX ReARMed core calls and stuff */ int in_type1, in_type2; int in_a1[2] = { 127, 127 }, in_a2[2] = { 127, 127 }; @@ -295,12 +299,12 @@ unsigned retro_get_region(void) void *retro_get_memory_data(unsigned id) { - return NULL; + return Mcd1Data; } size_t retro_get_memory_size(unsigned id) { - return 0; + return MCD_SIZE; } void retro_reset(void) @@ -387,6 +391,9 @@ void retro_init(void) level = 1; environ_cb(RETRO_ENVIRONMENT_SET_PERFORMANCE_LEVEL, &level); + + McdDisable[0] = 0; + McdDisable[1] = 1; } void retro_deinit(void) -- cgit v1.2.3 From 46aa5b98890412bca8487b28809df3ece137dba9 Mon Sep 17 00:00:00 2001 From: twinaphex Date: Tue, 4 Dec 2012 14:16:34 +0100 Subject: libretro: make RGB565 support into compile-time option all libretro frontends should support this no matter what --- Makefile | 3 ++- frontend/libretro.c | 12 +++++++----- jni/Android.mk | 2 +- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/Makefile b/Makefile index 0c7854d..2ca2fdd 100644 --- a/Makefile +++ b/Makefile @@ -120,7 +120,7 @@ OBJS += plugins/gpu_unai/gpulib_if.o ifeq "$(ARCH)" "arm" OBJS += plugins/gpu_unai/gpu_arm.o endif -plugins/gpu_unai/gpulib_if.o: CFLAGS += -DREARMED -O3 +plugins/gpu_unai/gpulib_if.o: CFLAGS += -DREARMED -O3 CC_LINK = $(CXX) endif @@ -163,6 +163,7 @@ USE_PLUGIN_LIB = 1 endif ifeq "$(PLATFORM)" "libretro" OBJS += frontend/libretro.o +CFLAGS += -DFRONTEND_SUPPORTS_RGB565 endif ifeq "$(USE_PLUGIN_LIB)" "1" diff --git a/frontend/libretro.c b/frontend/libretro.c index 15041bc..49e346b 100644 --- a/frontend/libretro.c +++ b/frontend/libretro.c @@ -30,7 +30,6 @@ static retro_audio_sample_batch_t audio_batch_cb; static void *vout_buf; static int samples_sent, samples_to_send; static int plugins_opened; -static int native_rgb565; /* memory card data */ extern char Mcd1Data[MCD_SIZE]; @@ -51,6 +50,7 @@ static void vout_set_mode(int w, int h, int raw_w, int raw_h, int bpp) { } +#ifdef FRONTEND_SUPPORTS_RGB565 static void convert(void *buf, size_t bytes) { unsigned int i, v, *p = buf; @@ -60,6 +60,7 @@ static void convert(void *buf, size_t bytes) p[i] = (v & 0x001f001f) | ((v >> 1) & 0x7fe07fe0); } } +#endif static void vout_flip(const void *vram, int stride, int bgr24, int w, int h) { @@ -90,8 +91,9 @@ static void vout_flip(const void *vram, int stride, int bgr24, int w, int h) } out: - if (!native_rgb565) - convert(vout_buf, w * h * 2); +#ifndef FRONTEND_SUPPORTS_RGB565 + convert(vout_buf, w * h * 2); +#endif video_cb(vout_buf, w, h, w * 2); pl_rearmed_cbs.flip_cnt++; } @@ -237,11 +239,12 @@ void retro_cheat_set(unsigned index, bool enabled, const char *code) bool retro_load_game(const struct retro_game_info *info) { +#ifdef FRONTEND_SUPPORTS_RGB565 enum retro_pixel_format fmt = RETRO_PIXEL_FORMAT_RGB565; if (environ_cb(RETRO_ENVIRONMENT_SET_PIXEL_FORMAT, &fmt)) { - native_rgb565 = 1; fprintf(stderr, "RGB565 supported, using it\n"); } +#endif if (plugins_opened) { ClosePlugins(); @@ -402,4 +405,3 @@ void retro_deinit(void) free(vout_buf); vout_buf = NULL; } - diff --git a/jni/Android.mk b/jni/Android.mk index 89af335..06b4379 100644 --- a/jni/Android.mk +++ b/jni/Android.mk @@ -89,7 +89,7 @@ LOCAL_SRC_FILES += ../frontend/main.c ../frontend/plugin.c # libretro LOCAL_SRC_FILES += ../frontend/libretro.c -LOCAL_CFLAGS += -O3 -ffast-math -funroll-loops -DNDEBUG -D_FILE_OFFSET_BITS=64 -DHAVE_LIBRETRO -DNO_FRONTEND +LOCAL_CFLAGS += -O3 -ffast-math -funroll-loops -DNDEBUG -D_FILE_OFFSET_BITS=64 -DHAVE_LIBRETRO -DNO_FRONTEND -DFRONTEND_SUPPORTS_RGB565 LOCAL_C_INCLUDES += $(LOCAL_PATH)/../include LOCAL_LDLIBS := -lz -llog -- cgit v1.2.3 From bcbe4aa4b45d8d37a6a3f1d80b4da1f3beb2be16 Mon Sep 17 00:00:00 2001 From: twinaphex Date: Tue, 4 Dec 2012 14:36:01 +0100 Subject: libretro: call video_cb on every frame We need to do video_cb in retro_run every frame instead of just once every time the video callback is called - otherwise we will get very bad/skippy framerates. Performance is much improved now in nearly all games. --- frontend/libretro.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/frontend/libretro.c b/frontend/libretro.c index 49e346b..e505804 100644 --- a/frontend/libretro.c +++ b/frontend/libretro.c @@ -62,6 +62,9 @@ static void convert(void *buf, size_t bytes) } #endif +static unsigned game_width; +static unsigned game_height; + static void vout_flip(const void *vram, int stride, int bgr24, int w, int h) { unsigned short *dest = vout_buf; @@ -94,8 +97,8 @@ out: #ifndef FRONTEND_SUPPORTS_RGB565 convert(vout_buf, w * h * 2); #endif - video_cb(vout_buf, w, h, w * 2); - pl_rearmed_cbs.flip_cnt++; + game_width = w; + game_height = h; } static void vout_close(void) @@ -353,6 +356,8 @@ void retro_run(void) psxCpu->Execute(); samples_to_send += 44100 / 60; + video_cb(vout_buf, game_width, game_height, game_width * 2); + pl_rearmed_cbs.flip_cnt++; } void retro_init(void) -- cgit v1.2.3 From 2ee53c487bfaa112fec8f740ae05717a79994264 Mon Sep 17 00:00:00 2001 From: twinaphex Date: Tue, 4 Dec 2012 16:38:01 +0100 Subject: libretro: Move flip screen counter increment back to end of flip screen callback --- frontend/libretro.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/libretro.c b/frontend/libretro.c index e505804..180c1d7 100644 --- a/frontend/libretro.c +++ b/frontend/libretro.c @@ -99,6 +99,7 @@ out: #endif game_width = w; game_height = h; + pl_rearmed_cbs.flip_cnt++; } static void vout_close(void) @@ -357,7 +358,6 @@ void retro_run(void) samples_to_send += 44100 / 60; video_cb(vout_buf, game_width, game_height, game_width * 2); - pl_rearmed_cbs.flip_cnt++; } void retro_init(void) -- cgit v1.2.3 From 7df396ea8c8eff6094e999f5c67b5f6b7e599199 Mon Sep 17 00:00:00 2001 From: Toad King Date: Tue, 4 Dec 2012 19:26:09 -0500 Subject: libretro: initialize blank memory card --- frontend/libretro.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/frontend/libretro.c b/frontend/libretro.c index 180c1d7..6212980 100644 --- a/frontend/libretro.c +++ b/frontend/libretro.c @@ -41,6 +41,39 @@ int in_a1[2] = { 127, 127 }, in_a2[2] = { 127, 127 }; int in_keystate; int in_enable_vibration; +static void init_memcard(char *mcd_data) +{ + unsigned off = 0; + unsigned i; + + memset(mcd_data, 0, MCD_SIZE); + + mcd_data[off++] = 'M'; + mcd_data[off++] = 'C'; + off += 0x7d; + mcd_data[off++] = 0x0e; + + for (i = 0; i < 15; i++) { + mcd_data[off++] = 0xa0; + off += 0x07; + mcd_data[off++] = 0xff; + mcd_data[off++] = 0xff; + off += 0x75; + mcd_data[off++] = 0xa0; + } + + for (i = 0; i < 20; i++) { + mcd_data[off++] = 0xff; + mcd_data[off++] = 0xff; + mcd_data[off++] = 0xff; + mcd_data[off++] = 0xff; + off += 0x04; + mcd_data[off++] = 0xff; + mcd_data[off++] = 0xff; + off += 0x76; + } +} + static int vout_open(void) { return 0; @@ -402,6 +435,7 @@ void retro_init(void) McdDisable[0] = 0; McdDisable[1] = 1; + init_memcard(Mcd1Data); } void retro_deinit(void) -- cgit v1.2.3 From 460f4c37a6fa4fbebba78fb82d153213442e2336 Mon Sep 17 00:00:00 2001 From: Toad King Date: Tue, 4 Dec 2012 19:26:23 -0500 Subject: update .gitignore --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index e6fc06b..2500270 100644 --- a/.gitignore +++ b/.gitignore @@ -10,3 +10,4 @@ config.log frontend/revision.h tools .pcsx/ +obj/ -- cgit v1.2.3 From e2bdb933ecee40a0c4caf14a20f5e642e3b93120 Mon Sep 17 00:00:00 2001 From: notaz Date: Mon, 10 Dec 2012 03:38:46 +0200 Subject: libretro: only pass fb to video_cb when it's updated --- frontend/libretro.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/frontend/libretro.c b/frontend/libretro.c index 6212980..8256fe1 100644 --- a/frontend/libretro.c +++ b/frontend/libretro.c @@ -97,6 +97,7 @@ static void convert(void *buf, size_t bytes) static unsigned game_width; static unsigned game_height; +static unsigned game_fb_dirty; static void vout_flip(const void *vram, int stride, int bgr24, int w, int h) { @@ -132,7 +133,8 @@ out: #endif game_width = w; game_height = h; - pl_rearmed_cbs.flip_cnt++; + game_fb_dirty = 1; + pl_rearmed_cbs.flip_cnt++; } static void vout_close(void) @@ -390,7 +392,9 @@ void retro_run(void) psxCpu->Execute(); samples_to_send += 44100 / 60; - video_cb(vout_buf, game_width, game_height, game_width * 2); + + video_cb(game_fb_dirty ? vout_buf : NULL, game_width, game_height, game_width * 2); + game_fb_dirty = 0; } void retro_init(void) -- cgit v1.2.3 From cc4f9b703ba166301a31ef6c695e1d02572e6bc4 Mon Sep 17 00:00:00 2001 From: notaz Date: Mon, 10 Dec 2012 18:42:13 +0200 Subject: libretro: minor cleanups --- frontend/libretro.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/frontend/libretro.c b/frontend/libretro.c index 8256fe1..bdcf519 100644 --- a/frontend/libretro.c +++ b/frontend/libretro.c @@ -83,7 +83,7 @@ static void vout_set_mode(int w, int h, int raw_w, int raw_h, int bpp) { } -#ifdef FRONTEND_SUPPORTS_RGB565 +#ifndef FRONTEND_SUPPORTS_RGB565 static void convert(void *buf, size_t bytes) { unsigned int i, v, *p = buf; @@ -129,12 +129,12 @@ static void vout_flip(const void *vram, int stride, int bgr24, int w, int h) out: #ifndef FRONTEND_SUPPORTS_RGB565 - convert(vout_buf, w * h * 2); + convert(vout_buf, w * h * 2); #endif - game_width = w; - game_height = h; - game_fb_dirty = 1; - pl_rearmed_cbs.flip_cnt++; + game_width = w; + game_height = h; + game_fb_dirty = 1; + pl_rearmed_cbs.flip_cnt++; } static void vout_close(void) -- cgit v1.2.3 From 5ca2ec64779fee99d0fc347330a83ae5e982d282 Mon Sep 17 00:00:00 2001 From: notaz Date: Tue, 11 Dec 2012 01:37:33 +0200 Subject: libretro: set cycle_multiplier --- frontend/libretro.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/frontend/libretro.c b/frontend/libretro.c index 4e509a0..3431685 100644 --- a/frontend/libretro.c +++ b/frontend/libretro.c @@ -437,6 +437,15 @@ void retro_init(void) level = 1; environ_cb(RETRO_ENVIRONMENT_SET_PERFORMANCE_LEVEL, &level); + /* Set how much slower PSX CPU runs * 100 (so that 200 is 2 times) + * we have to do this because cache misses and some IO penalties + * are not emulated. Warning: changing this may break compatibility. */ +#ifdef __ARM_ARCH_7A__ + cycle_multiplier = 175; +#else + cycle_multiplier = 200; +#endif + McdDisable[0] = 0; McdDisable[1] = 1; init_memcard(Mcd1Data); -- cgit v1.2.3 From 8f00f96ca84ba1d8ba30d4850c0b1d143efa5989 Mon Sep 17 00:00:00 2001 From: notaz Date: Tue, 11 Dec 2012 01:46:30 +0200 Subject: misc: make error message remind about common mistake --- libpcsxcore/misc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libpcsxcore/misc.c b/libpcsxcore/misc.c index ad2e5d5..bb55257 100644 --- a/libpcsxcore/misc.c +++ b/libpcsxcore/misc.c @@ -506,7 +506,8 @@ int Load(const char *ExePath) { retval = -1; break; case INVALID_EXE: - SysPrintf(_("This file does not appear to be a valid PSX file.\n")); + SysPrintf(_("This file does not appear to be a valid PSX EXE file.\n")); + SysPrintf(_("(did you forget -cdfile ?)\n")); retval = -1; break; } -- cgit v1.2.3 From 70d56ca34a084bf613247c027f58b58055d75ecd Mon Sep 17 00:00:00 2001 From: notaz Date: Tue, 11 Dec 2012 02:20:42 +0200 Subject: libretro: handle borders --- frontend/libretro.c | 31 ++++++++++++++++++++----------- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/frontend/libretro.c b/frontend/libretro.c index 3431685..3b366d4 100644 --- a/frontend/libretro.c +++ b/frontend/libretro.c @@ -28,6 +28,9 @@ static retro_environment_t environ_cb; static retro_audio_sample_batch_t audio_batch_cb; static void *vout_buf; +static int vout_width, vout_height; +static int vout_doffs_old, vout_fb_dirty; + static int samples_sent, samples_to_send; static int plugins_opened; @@ -81,6 +84,8 @@ static int vout_open(void) static void vout_set_mode(int w, int h, int raw_w, int raw_h, int bpp) { + vout_width = w; + vout_height = h; } #ifndef FRONTEND_SUPPORTS_RGB565 @@ -95,15 +100,12 @@ static void convert(void *buf, size_t bytes) } #endif -static unsigned game_width; -static unsigned game_height; -static unsigned game_fb_dirty; - static void vout_flip(const void *vram, int stride, int bgr24, int w, int h) { unsigned short *dest = vout_buf; const unsigned short *src = vram; - int dstride = w, h1 = h; + int dstride = vout_width, h1 = h; + int doffs; if (vram == NULL) { // blanking @@ -111,6 +113,15 @@ static void vout_flip(const void *vram, int stride, int bgr24, int w, int h) goto out; } + doffs = (vout_height - h) * dstride; + doffs += (dstride - w) / 2 & ~1; + if (doffs != vout_doffs_old) { + // clear borders + memset(vout_buf, 0, dstride * h * 2); + vout_doffs_old = doffs; + } + dest += doffs; + if (bgr24) { // XXX: could we switch to RETRO_PIXEL_FORMAT_XRGB8888 here? @@ -129,11 +140,9 @@ static void vout_flip(const void *vram, int stride, int bgr24, int w, int h) out: #ifndef FRONTEND_SUPPORTS_RGB565 - convert(vout_buf, w * h * 2); + convert(vout_buf, vout_width * vout_height * 2); #endif - game_width = w; - game_height = h; - game_fb_dirty = 1; + vout_fb_dirty = 1; pl_rearmed_cbs.flip_cnt++; } @@ -393,8 +402,8 @@ void retro_run(void) samples_to_send += 44100 / 60; - video_cb(game_fb_dirty ? vout_buf : NULL, game_width, game_height, game_width * 2); - game_fb_dirty = 0; + video_cb(vout_fb_dirty ? vout_buf : NULL, vout_width, vout_height, vout_width * 2); + vout_fb_dirty = 0; } void retro_init(void) -- cgit v1.2.3