diff options
| author | Paul Gilbert | 2012-10-13 19:38:53 +1100 |
|---|---|---|
| committer | Paul Gilbert | 2012-10-13 19:38:53 +1100 |
| commit | 193686770ce53890807660a35880480b54d9df90 (patch) | |
| tree | 87fe256517d1a5637685fb4511b9ad3312a61763 /engines/hopkins | |
| parent | da339dc822325115a36eef6a4c3629b7ac3e7b6b (diff) | |
| download | scummvm-rg350-193686770ce53890807660a35880480b54d9df90.tar.gz scummvm-rg350-193686770ce53890807660a35880480b54d9df90.tar.bz2 scummvm-rg350-193686770ce53890807660a35880480b54d9df90.zip | |
HOPKINS: Put a TODO in Capture_Mem to clip reading to within the passed surface
Diffstat (limited to 'engines/hopkins')
| -rw-r--r-- | engines/hopkins/graphics.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/engines/hopkins/graphics.cpp b/engines/hopkins/graphics.cpp index 4e240902d2..b1bce4840f 100644 --- a/engines/hopkins/graphics.cpp +++ b/engines/hopkins/graphics.cpp @@ -1298,7 +1298,8 @@ void GraphicsManager::Capture_Mem(const byte *srcSurface, byte *destSurface, int unsigned int i; int rowCount2; - assert(xs <= SCREEN_WIDTH && ys <= SCREEN_HEIGHT); + // TODO: This code in the original is potentially dangerous, as it doesn't clip the area to within + // the screen, and so thus can read areas outside of the allocated surface buffer srcP = xs + nbrligne2 * ys + srcSurface; destP = destSurface; rowCount = height; |