aboutsummaryrefslogtreecommitdiff
path: root/scumm
diff options
context:
space:
mode:
authorMax Horn2005-04-20 20:20:31 +0000
committerMax Horn2005-04-20 20:20:31 +0000
commit9216ca4ed5b42339a2807a07c4a13525b5943c5c (patch)
tree2cb5af2a95f8e96dc69c70ed3d2aa1815fe8e439 /scumm
parent6e3fd4527e03f4eefc5ca74b023aac4ec5b77d12 (diff)
downloadscummvm-rg350-9216ca4ed5b42339a2807a07c4a13525b5943c5c.tar.gz
scummvm-rg350-9216ca4ed5b42339a2807a07c4a13525b5943c5c.tar.bz2
scummvm-rg350-9216ca4ed5b42339a2807a07c4a13525b5943c5c.zip
Added FIXME for the _haveMsg hack
svn-id: r17720
Diffstat (limited to 'scumm')
-rw-r--r--scumm/string.cpp5
1 files changed, 5 insertions, 0 deletions
diff --git a/scumm/string.cpp b/scumm/string.cpp
index 4778bdbe95..410a8dcf4d 100644
--- a/scumm/string.cpp
+++ b/scumm/string.cpp
@@ -329,6 +329,7 @@ void ScummEngine::CHARSET_1() {
a->startAnimActor(frme);
break;
case 10:
+ // Note the similarity to the code in unkMessage1()
talk_sound_a = buffer[0] | (buffer[1] << 8) | (buffer[4] << 16) | (buffer[5] << 24);
talk_sound_b = buffer[8] | (buffer[9] << 8) | (buffer[12] << 16) | (buffer[13] << 24);
buffer += 14;
@@ -339,6 +340,10 @@ void ScummEngine::CHARSET_1() {
// This is actually a hack added by ScummVM; the original did
// subtitle hiding in some other way. I am not sure exactly
// how, though.
+ // FIXME: This is actually a rather ugly hack, and we should consider
+ // replacing it with something better; problem is that _haveMsg is saved,
+ // so we need to cope with old save games if we ever change this.
+ // And BTW Fingolfin was responsible for this silly bad hack. Stupid me! :-).
if (_haveMsg == 0xFF)
_haveMsg = 0xFE;
break;