aboutsummaryrefslogtreecommitdiff
path: root/gui/console.h
diff options
context:
space:
mode:
Diffstat (limited to 'gui/console.h')
-rw-r--r--gui/console.h26
1 files changed, 13 insertions, 13 deletions
diff --git a/gui/console.h b/gui/console.h
index c683a1f619..d347112862 100644
--- a/gui/console.h
+++ b/gui/console.h
@@ -33,7 +33,7 @@ namespace GUI {
class ScrollBarWidget;
/*
- FIXME #1: The console dialog code has some fundamental problems.
+ FIXME #1: The console dialog code has some fundamental problems.
First of, note the conflict between the (constant) value kCharsPerLine, and the
(variable) value _pageWidth. Look a bit at the code get familiar with them,
then return...
@@ -41,26 +41,26 @@ class ScrollBarWidget;
When the user changes the scaler, the console will get resized. If the dialog
becomes smaller because of this, we may have to rewrap text. If the resolution
is then increased again, we'd end up with garbled content.
-
- One can now either ignore this problem (and modify our code accordingly to
+
+ One can now either ignore this problem (and modify our code accordingly to
implement this simple rewrapping -- we currently don't do that at all!).
-
+
Or, one can go and implement a more complete console, by replacing the
_buffer by a real line buffer -- an arrach of char* pointers.
This will allow one to implement resizing perfectly, but has the drawback
of making things like scrolling, drawing etc. more complicated.
-
+
Either way, the current situation is bad, and we should resolve it one way
or the other (and if you can think of a thirds, feel free to suggest it).
-
-
-
+
+
+
FIXME #2: Another problem is that apparently _pageWidth isn't computed quite
correctly. The current line ends well before reaching the right side of the
console dialog. That's irritating and should be fixed.
-
-
- FIXME #3: The scroll bar is not shown initially, but the area it would
+
+
+ FIXME #3: The scroll bar is not shown initially, but the area it would
occupy is not used for anything else. As a result, the gap described above
becomes even wider and thus even more irritating.
*/
@@ -74,7 +74,7 @@ protected:
kBufferSize = 32768,
kCharsPerLine = 128,
kLineBufferSize = 256,
-
+
kHistorySize = 20
};
@@ -156,7 +156,7 @@ public:
_completionCallbackProc = proc;
_completionCallbackRefCon = refCon;
}
-
+
int getCharsPerLine() {
return _pageWidth;
}