aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2006-03-13Fix a few valgrind warningsTravis Howell
svn-id: r21258
2006-03-13Fix to remove warning on validating frame offsets in animation decoderPaul Gilbert
svn-id: r21257
2006-03-13Added further disassembly of animation decoder routinePaul Gilbert
svn-id: r21256
2006-03-13Add proper handling for animations with frame offset tables during decodingPaul Gilbert
svn-id: r21255
2006-03-13Changed temp variable from byte to word to fix decoding of some animation ↵Paul Gilbert
resources svn-id: r21254
2006-03-13Confirmed it is safe to remove workaround for Macintosh HE99 version of water.Travis Howell
svn-id: r21253
2006-03-13Add opcode difference in setObjectName opcode for C64 maniacTravis Howell
svn-id: r21251
2006-03-13Add masking support for C64 maniac, not perfectTravis Howell
svn-id: r21250
2006-03-13Fix object glitches in C64 maniacTravis Howell
svn-id: r21249
2006-03-13Update and restore old debug code for maskingTravis Howell
svn-id: r21248
2006-03-12Until now, we have confusingly used the terms "state" or "table" where weTorbjörn Andersson
really mean "channel". Fixed that: OutputState -> Channel _curTable -> _curChannel _outputTables[] -> _channels[] The biggest change was modifying all the "state" and "table" local variables and function parameters. Ahd, at no extra charge: _outputTable[] -> _regOffset[] svn-id: r21247
2006-03-12Renamed callback1 to primaryEffect and callback2 to secondaryEffect.Torbjörn Andersson
svn-id: r21246
2006-03-12Cleaned up comment and did some more renaming:Torbjörn Andersson
unk4 -> position (measured on a very short ruler :-) unk5 -> duration svn-id: r21245
2006-03-12- Renames some functions:Johannes Schickel
updateCallback31 -> update_setChannelTempo updateCallback42 -> update_resetToGlobalTempo updateCallback55 -> update_setTempoReset - Renames some vars: unk1 -> tempo unk6 -> tempoReset - Fixes tempo bugs svn-id: r21244
2006-03-12Updated for Jamieson630's latest iMUSE changes.Torbjörn Andersson
svn-id: r21242
2006-03-12IMuse SysEx processing now handled by client-specified callbacks. This ↵Jamieson Christian
removes all game-specific references from the Player class. Bloodshed Dev-C++ project file updated. svn-id: r21241
2006-03-12- Changes usage of regBx to regAx in primaryEffect2 (seems to be a bug ↵Johannes Schickel
introduced when renaming). - Changes unk41 and unk32 to signed. - Fixes wrong sound when dropping items (that was also a little bug in primaryEffect2) svn-id: r21240
2006-03-12Compensate for rounding errors in _samplesPerCallback by having readBuffer()Torbjörn Andersson
generate "leap samples". I doubt this will make any noticeable difference, but at least now we can probably rule out timer inaccuracies from the list of possible suspects for the remaining bugs. Also removed unnecessary mutex locking/unlocking from readBuffer(), spotted by LordHoto. svn-id: r21239
2006-03-12Corrects former commit which deleted sound file loading after the scene with ↵Johannes Schickel
malcolm and kallak. Also corrects callback50() which seem to improve the sound a bit in the kallak writing scene. svn-id: r21238
2006-03-12After several days, telling LordHoto over and over that "no, I don't think theTorbjörn Andersson
timer inaccuracies can cause that kind of problems, or we'd have noticed it in the other game engines as well", guess what? The other game engines do not necessary use a timer for their Adlib music. So now Kyra doesn't either. Fortunately for my dignity, the music is still a bit uneven at times, but the situation does seem to have improved a bit, and the sound effects sound better to me now. svn-id: r21237
2006-03-12Fixes non looping tracks and a fading bug, which silenced the music, with mt-32.Johannes Schickel
svn-id: r21236
2006-03-12Music in the last two intro scenes plays now again with adlib.Johannes Schickel
Cleaned up the sound code a bit (removed some unneeded functions). svn-id: r21234
2006-03-12Added debug message for the standard "note on" opcodes as well.Torbjörn Andersson
svn-id: r21233
2006-03-12And now, for a change, some more renamings:Torbjörn Andersson
update1() -> setupDuration() updateAndOutput1() -> setupNote() setInstrument() -> setupInstrument() (just for the symmetry) updateAndOutput3() -> noteOn() That made the following two renamings seem natural: updateCallback10() -> update_playRest() updateCallback27() -> update_playNote() I decided to number the secondary effects, even though there's only one: update_setupSecondaryEffect() -> update_setupSecondaryEffect1() update_removeSecondaryEffect() -> update_removeSecondaryEffect1() And finally, I renamed the effects callbacks: stateCallback1_1() -> primaryEffect1() stateCallback1_2() -> primaryEffect2() stateCallback2_1() -> secondaryEffect1() svn-id: r21232
2006-03-12Unfortunately the workaround for Macintosh version of water is still required.Travis Howell
svn-id: r21231
2006-03-12Added a block of comments about command parsing and timing. Perhaps it will beTorbjörn Andersson
of use in tracking down the tempo bugs. svn-id: r21230
2006-03-12Adjust basename array setting in HE99+ games, for filename substitutionTravis Howell
svn-id: r21229
2006-03-12Adjust version setting for Macintosh versions of HE80+ games, which is ↵Travis Howell
checked by water svn-id: r21228
2006-03-12Use script support for Macintosh versions of HE80+ gamesTravis Howell
svn-id: r21227
2006-03-12Revert mistaken commit of local debug codeTravis Howell
svn-id: r21222
2006-03-12Revert mistaken commit of local debug codeTravis Howell
svn-id: r21220
2006-03-12Correct mistake in md5 tables for Simon the Sorcerer 2 (DOS Floppy)Travis Howell
svn-id: r21219
2006-03-11Some more renaming:Torbjörn Andersson
updateCallback18() -> update_setupPrimaryEffect1() updateCallback19() -> update_removePrimaryEffect1() updateCallback21() -> update_setupPrimaryEffect2() updateCallback40() -> update_removePrimaryEffect2() updateCallback14() -> update_setupSecondaryEffect() updateCallback30() -> update_removeSecondaryEffect() updateCallback37() -> update_changeExtraLevel1() updateCallback34() -> update_changeExtraLevel2() svn-id: r21217
2006-03-11Fix endian issue in getArrayDim()Travis Howell
svn-id: r21216
2006-03-11Removed inclusion of non-existing imuse_sysex.h to make ScummVM compile again.Torbjörn Andersson
svn-id: r21214
2006-03-11Another ScummEngine reference in IMuse bites the dust.Jamieson Christian
svn-id: r21213
2006-03-10Remove unused case in o5_actorOps, which is never triggered by any game scriptsTravis Howell
svn-id: r21212
2006-03-10o6_setObjectName is never used by HE72+ gamesTravis Howell
svn-id: r21211
2006-03-10Add Russian puttrace and pajama3Eugene Sandulenko
svn-id: r21209
2006-03-10More comments, and some very minor cleanup.Torbjörn Andersson
svn-id: r21208
2006-03-10Added comment detailing what I believe I know about the remaining "unk"Torbjörn Andersson
variables in OutputState. svn-id: r21207
2006-03-10Further guesswork: 'unk2' appears to be the priority of a sound, since theTorbjörn Andersson
callbackOutput() and updateCallback3() functions won't change the channel data pointer unless the new sound has a higher unk2 and the current one. Since it's set to 0 when the data pointer is nulled, I've changed the priority to be unsigned. The updateCallback22() function is now update_setPriority(). svn-id: r21206
2006-03-10Fleshed out some guesswork comments.Torbjörn Andersson
svn-id: r21205
2006-03-10Renamed _unkOutputByte1 _curRegOffset. It doesn't always correspond to theTorbjörn Andersson
_curTable channel, but it probably does so whenever both of them are used together. svn-id: r21204
2006-03-10Added guesswork comments for stateCallback2_1() and its related functions andTorbjörn Andersson
variables, and cleaned it up slightly. (Some of its variables are now signed.) svn-id: r21203
2006-03-10Added guesswork comments for stateCallback1_1() and its related functions andTorbjörn Andersson
variables. svn-id: r21202
2006-03-10Fixed some obvious errors in the comments I added before.Torbjörn Andersson
svn-id: r21201
2006-03-10Added some guesswork comments about stateCallback1_2() and related functionsTorbjörn Andersson
and variables. svn-id: r21200
2006-03-10The calculateLowByte1() and 2() functions are used for calculating the "totalTorbjörn Andersson
level", which I believe is the individual channel volume. (The functions also return the "scaling level" bits, but they are preserved, not calculated.) I have renamed these functions calculateOpLevel1() and 2(). The unk25 and unk26 variables have been renamed opLevel1 and opLevel2. These are called oplvl_1 and oplvl_2 in our MidiDriver_ADLIB class. The unk26, unk27 and unk28 variables are potentially added to both operator levels, and have been renamed opExtraLevel1, opExtralevel2 and opExtraLevel3. The updateCallback25() function has been remamed update_setExtraLevel1(). The updateCallback33() function has been renamed update_setExtraLevel2(). The updateCallback32() function has been renamed update_setExtraLevel3(). Note that these callbacks aren't quite as similar as their names would seem to indicate: They differ in whether or not the volume is updated and/or how the parameters are passed. svn-id: r21199
2006-03-10Renamed "algorithm" "twoChan" to be more consistent with our MidiDriver_ADLIBTorbjörn Andersson
class, where the corresponding variable is called _twochan. svn-id: r21198