Age | Commit message (Collapse) | Author | |
---|---|---|---|
2018-07-31 | CRUISE: Fix Possible Invalid Thumbnail Pointer Access. | D G Turner | |
2018-04-07 | ALL: Load savegame thumbnail only when necessary | Adrian Frühwirth | |
This commit introduces the following changes: 1. Graphics::loadThumbnail() Now returns a boolean and takes a new argument skipThumbnail which defaults to false. In case of true, loadThumbnail() reads past the thumbnail data in the input stream instead of actually loading the thumbnail. This simplifies savegame handling where, up until now, many engines always read the whole savegame metadata (including the thumbnail) and then threw away the thumbnail when not needed (which is in almost all cases, the most common exception being MetaEngine::querySaveMetaInfos() which is responsible for loading savegame metadata for displaying it in the GUI launcher. 2. readSavegameHeader() Engines which already implement such a method (name varies) now take a new argument skipThumbnail (default: true) which is passed through to loadThumbnail(). This means that the default case for readSavegameHeader() is now _not_ loading the thumbnail from a savegame and just reading past it. In those cases, e.g. querySaveMetaInfos(), where we actually are interested in loading the thumbnail readSavegameHeader() needs to explicitely be called with skipThumbnail == false. Engines whose readSavegameHeader() (name varies) already takes an argument loadThumbnail have been adapted to have a similar prototype and semantics. I.e. readSaveHeader(in, loadThumbnail, header) now is readSaveHeader(in, header, skipThumbnail). 3. Error handling Engines which previously did not check the return value of readSavegameHeader() (name varies) now do so ensuring that possibly broken savegames (be it a broken thumbnail or something else) don't make it into the GUI launcher list in the first place. | |||
2014-06-10 | CRUISE: Remove some useless variables, use a boolean for a variable | Strangerke | |
2014-06-09 | CRUISE: Initialize some variables in the contractor, change some variables ↵ | Strangerke | |
to boolean | |||
2014-06-08 | CRUISE: Directly use assert. | Johannes Schickel | |
This fixes an ASSERT macro redefinition when compiling the Symbian port. See bug #6622 "SYMBIAN: CRUISE: warning: `ASSERT' redefined". | |||
2014-06-06 | CRUISE: disable more efficiently some code | Strangerke | |
2014-06-01 | CRUISE: Reduce the scope of variables used in the for loops | Strangerke | |
2014-03-30 | ALL: Resolve multiple clang warnings | Max Horn | |
2014-02-18 | CRUISE: Make GPL headers consistent in themselves. | Johannes Schickel | |
2012-02-15 | JANITORIAL: Fix missing whitespace in pointer cast | Tarek Soliman | |
find -name '*.h' -or -name '*.cpp' | xargs sed -r -i 's@\(([A-Za-z0-9]+)\*\)@(\1 *)@g' This seems to have caught some params as well which is not undesirable IMO. It also caught some strings containing this which is undesirable so I excluded them manually. (engines/sci/engine/kernel_tables.h) | |||
2011-11-21 | CRUISE: Added explicit freeing of thumbnail surface pixels | Paul Gilbert | |
2011-08-07 | GRAPHICS: Simplify the interface of Graphics::loadThumbnail(). | Christoph Mallon | |
Now it returns the Surface, so the caller does not need to create one and pass it. | |||
2011-05-12 | GIT: Clean up: Suppress SVN tags, now useless | strangerke | |
2011-04-28 | JANITORIAL: Reduce header dependencies in shared code | Ori Avtalion | |
Some backends may break as I only compiled SDL | |||
2010-11-07 | LURE: Convert printf to debug/warning | Max Horn | |
Exception: The "decompiler" code still uses fopen/fprintf etc. but it is disabled by default, hence I am ignoring it for now. svn-id: r54108 | |||
2010-08-09 | CRUISE: Eliminate global constructors | Eugene Sandulenko | |
svn-id: r51936 | |||
2010-02-20 | Put in a warning in case there is ever too long a background resource name ↵ | Paul Gilbert | |
when saving a game svn-id: r48095 | |||
2010-01-25 | Strip trailing spaces/tabs. | Johannes Schickel | |
svn-id: r47541 | |||
2010-01-03 | Fixed a bunch of cppcheck warnings. Mostly about checking if a pointer is null | Torbjörn Andersson | |
before freeing it, which isn't necessary. svn-id: r46941 | |||
2009-11-02 | Changed foo(void) to foo() in almost all non-backend source files | Max Horn | |
svn-id: r45616 | |||
2009-10-10 | Fixed memory leaks in savegame restoring | Paul Gilbert | |
svn-id: r44863 | |||
2009-10-09 | Fixed all memory leaks as far as the initial title screen | Paul Gilbert | |
svn-id: r44814 | |||
2009-10-09 | Set up a basic tracing system for all memory allocations to help track down ↵ | Paul Gilbert | |
memory leaks svn-id: r44808 | |||
2009-07-03 | Bugfix for loading savegames where the active resource file database isn't ↵ | Paul Gilbert | |
completely filled svn-id: r42047 | |||
2009-06-20 | Added proper saving of music state to savegames so music resumes when a ↵ | Paul Gilbert | |
savegame is loaded. svn-id: r41702 | |||
2009-06-14 | Beginnings of music support for Cruise, based on the cine engine sound code ↵ | Paul Gilbert | |
(note that the music played isn't yet correct, though) svn-id: r41506 | |||
2009-06-10 | Added variable to savegame format so that savegames can be correctly loaded ↵ | Paul Gilbert | |
from the ScummVM launcher svn-id: r41423 | |||
2009-06-01 | Removed the remaining two FIXME's - my analysis of the data indicates no ↵ | Paul Gilbert | |
issues with structure packing, and all multi-byte data accesses are wrapped using loadShort/saveShort, which is endian safe svn-id: r41096 | |||
2009-06-01 | Converted the saving of perso structure data to proper endian-safe serialisation | Paul Gilbert | |
svn-id: r41093 | |||
2009-05-28 | Replaced the original implementation of walk box handling with a cleaner, ↵ | Paul Gilbert | |
structure array based one svn-id: r40954 | |||
2009-05-24 | Strip trailing whitespaces in the whole code base. | Johannes Schickel | |
svn-id: r40867 | |||
2009-05-19 | COMMON: Removed Stream::ioFailed() and clearIOFailed(), as they are ↵ | Max Horn | |
deprecated; however, retained ioFailed in SeekableReadStream and File for now (so for now this mainly affects WriteStream subclasses) svn-id: r40725 | |||
2009-05-19 | Improved Common::Serializer in several ways: | Max Horn | |
* Added support versioned serialization * Added a convenience API for handling 'magic IDs' transparently * Exposed the err()/clearErr() methods of the underlying streams * Added a basic unit test for versioned loading (more should be added, in particular for saving) * Removed the syncString(char *, uint16) alias for syncBytes(byte *buf, uint32 size) svn-id: r40723 | |||
2009-05-17 | Properly named the script structure offset field, and fixed an endian bug | Paul Gilbert | |
svn-id: r40634 | |||
2009-05-16 | Replaced value with proper constant, and named a previously un-named ↵ | Paul Gilbert | |
structure field svn-id: r40616 | |||
2009-05-15 | Bugfix to saving the width of a cached background area - the previous code ↵ | Paul Gilbert | |
was, for some reason, saving the width divided by 2.. this was causing corruptions during reload for cached areas with an odd horizontal width svn-id: r40595 | |||
2009-05-15 | Corrected saving/loading of cached background areas | Paul Gilbert | |
svn-id: r40594 | |||
2009-04-18 | Added support for the global menu save/loading, and changed the savegame ↵ | Paul Gilbert | |
format to store the savegame name and thumbnail svn-id: r39979 | |||
2009-04-04 | Replaced all occurrences of the constant '257' with the existing constant ↵ | Paul Gilbert | |
'NUM_FILE_ENTRIES' svn-id: r39824 | |||
2009-04-01 | Laid the basics for music handling | Paul Gilbert | |
svn-id: r39786 | |||
2009-03-24 | CRUISE: Fixed bug when loading backgroundIncrustStruct::saveWidth (don't ↵ | Max Horn | |
divide by 2, rather *multiply* by 2); also some cleanup svn-id: r39657 | |||
2009-03-16 | Converted the Cruise engine to use the new Common::Serializer class | Paul Gilbert | |
svn-id: r39443 | |||
2009-02-11 | Removed deprecated method | Paul Gilbert | |
svn-id: r36258 | |||
2009-02-09 | Changed the save/load process to use a common serialiser | Paul Gilbert | |
svn-id: r36253 | |||
2009-01-29 | A ton of code formatting fixes; also fixed warnings about single line loops ↵ | Max Horn | |
like 'while(cond);' by inserting newlines svn-id: r36127 | |||
2009-01-16 | Code formatting fixes, automatically performed by astyle | Max Horn | |
svn-id: r35870 | |||
2009-01-16 | Mark cruise save/load code as not endian safe | Max Horn | |
svn-id: r35869 | |||
2008-09-21 | Patch #2054467: CRUISE: 64bits fixes | Eugene Sandulenko | |
svn-id: r34622 | |||
2008-01-27 | Removed trailing spaces. | Jordi Vilalta Prat | |
svn-id: r30664 | |||
2007-12-27 | Early pathfinding | Vincent Hamm | |
svn-id: r30012 |