Age | Commit message (Collapse) | Author |
|
This commit introduces the following changes:
1. Graphics::loadThumbnail()
Now returns a boolean and takes a new argument skipThumbnail which
defaults to false. In case of true, loadThumbnail() reads past the
thumbnail data in the input stream instead of actually loading the
thumbnail. This simplifies savegame handling where, up until now,
many engines always read the whole savegame metadata (including
the thumbnail) and then threw away the thumbnail when not needed
(which is in almost all cases, the most common exception being
MetaEngine::querySaveMetaInfos() which is responsible for loading
savegame metadata for displaying it in the GUI launcher.
2. readSavegameHeader()
Engines which already implement such a method (name varies) now take
a new argument skipThumbnail (default: true) which is passed
through to loadThumbnail(). This means that the default case for
readSavegameHeader() is now _not_ loading the thumbnail from a
savegame and just reading past it. In those cases, e.g.
querySaveMetaInfos(), where we actually are interested in loading
the thumbnail readSavegameHeader() needs to explicitely be called
with skipThumbnail == false.
Engines whose readSavegameHeader() (name varies) already takes an
argument loadThumbnail have been adapted to have a similar
prototype and semantics.
I.e. readSaveHeader(in, loadThumbnail, header) now is
readSaveHeader(in, header, skipThumbnail).
3. Error handling
Engines which previously did not check the return value of
readSavegameHeader() (name varies) now do so ensuring that possibly
broken savegames (be it a broken thumbnail or something else) don't
make it into the GUI launcher list in the first place.
|
|
|
|
to boolean
|
|
This fixes an ASSERT macro redefinition when compiling the Symbian port.
See bug #6622 "SYMBIAN: CRUISE: warning: `ASSERT' redefined".
|
|
|
|
|
|
|
|
|
|
find -name '*.h' -or -name '*.cpp' | xargs sed -r -i 's@\(([A-Za-z0-9]+)\*\)@(\1 *)@g'
This seems to have caught some params as well which is not undesirable IMO.
It also caught some strings containing this which is undesirable so I
excluded them manually. (engines/sci/engine/kernel_tables.h)
|
|
|
|
Now it returns the Surface, so the caller does not need to create one and pass it.
|
|
|
|
Some backends may break as I only compiled SDL
|
|
Exception: The "decompiler" code still uses fopen/fprintf etc.
but it is disabled by default, hence I am ignoring it for now.
svn-id: r54108
|
|
svn-id: r51936
|
|
when saving a game
svn-id: r48095
|
|
svn-id: r47541
|
|
before freeing it, which isn't necessary.
svn-id: r46941
|
|
svn-id: r45616
|
|
svn-id: r44863
|
|
svn-id: r44814
|
|
memory leaks
svn-id: r44808
|
|
completely filled
svn-id: r42047
|
|
savegame is loaded.
svn-id: r41702
|
|
(note that the music played isn't yet correct, though)
svn-id: r41506
|
|
from the ScummVM launcher
svn-id: r41423
|
|
issues with structure packing, and all multi-byte data accesses are wrapped using loadShort/saveShort, which is endian safe
svn-id: r41096
|
|
svn-id: r41093
|
|
structure array based one
svn-id: r40954
|
|
svn-id: r40867
|
|
deprecated; however, retained ioFailed in SeekableReadStream and File for now (so for now this mainly affects WriteStream subclasses)
svn-id: r40725
|
|
* Added support versioned serialization
* Added a convenience API for handling 'magic IDs' transparently
* Exposed the err()/clearErr() methods of the underlying streams
* Added a basic unit test for versioned loading (more should be added, in particular for saving)
* Removed the syncString(char *, uint16) alias for syncBytes(byte *buf, uint32 size)
svn-id: r40723
|
|
svn-id: r40634
|
|
structure field
svn-id: r40616
|
|
was, for some reason, saving the width divided by 2.. this was causing corruptions during reload for cached areas with an odd horizontal width
svn-id: r40595
|
|
svn-id: r40594
|
|
format to store the savegame name and thumbnail
svn-id: r39979
|
|
'NUM_FILE_ENTRIES'
svn-id: r39824
|
|
svn-id: r39786
|
|
divide by 2, rather *multiply* by 2); also some cleanup
svn-id: r39657
|
|
svn-id: r39443
|
|
svn-id: r36258
|
|
svn-id: r36253
|
|
like 'while(cond);' by inserting newlines
svn-id: r36127
|
|
svn-id: r35870
|
|
svn-id: r35869
|
|
svn-id: r34622
|
|
svn-id: r30664
|
|
svn-id: r30012
|
|
svn-id: r29979
|