aboutsummaryrefslogtreecommitdiff
path: root/engines/draci/music.cpp
AgeCommit message (Collapse)Author
2011-06-02DRACI: Replace snprintf() usage with Common::String::format()D G Turner
Safer and less portability issues.
2011-05-12GIT: Clean up: Suppress SVN tags, now uselessstrangerke
2011-04-28JANITORIAL: Reduce header dependencies in shared codeOri Avtalion
Some backends may break as I only compiled SDL
2011-03-28AUDIO: Add Audio::MidiPlayer::createDriver(), let some engines use itMax Horn
2011-03-25AUDIO: Move more common code to Audio::MidiPlayerMax Horn
This also should fix some regressions from the previous commits, related to MidiParser's either being leaked, or being deleted and then used again (i.e., crashing). I tested as many games as I had available, but further testing of all affected engines is called for anyway.
2011-03-24DRACI: Change MusicPlayer to derive from Audio::MidiPlayerMax Horn
2011-03-24DRACI: Fix incorrect 'all notes off' handlingMax Horn
2011-03-23ENGINES: Remove unused MIDI pass-through codeMax Horn
2011-03-23ENGINES: Further simplify pseudo MidiDrivers; fix some regressionsMax Horn
The regression affected AGOS and maybe some others; specifically, the real MidiDriver would have been deleted twice -- I previously missed that the Engine instances takes care of freeing the real MidiDriver, not the MidiPlayer wrapping it. This commit should clarify the ownership of the real MidiDriver for most pseudo MidiDrivers.
2011-03-23AUDIO: Change several fake MidiDrivers to MidiDriver_BASE subclassesMax Horn
Many engines follow the advice in audio/midiparser.h and create a "pseudo-MidiDriver" subclass. But MidiParser really only needs a tiny subset of the MidiDriver capabilities, namely those found in MidiDriver_BASE. So we try to subclass from that whenever possible; this allows us to remove many stub methods, and enables further future simplifications.
2011-03-22AUDIO: Add pure virtual MidiDriver::isOpen() methodMax Horn
This in turn enables modifying MidiDriver_MPU401::close() to allow it to be called on a midi driver that has not yet been opened. The specific issue that triggered me to make these changes was a crash-upon-quit in HUGO, caused by it instantiating a midi driver, then encountering an error (missing hugo.dat) *before* having opened the new midi driver; the general cleanup code then tries to close the (not yet opened) midi driver -> kaboom Also fixed some engines which were leaking MidiDriver instances.
2011-02-09AUDIO: Rename sound/ dir to audio/Max Horn
svn-id: r55850
2010-09-15DRACI: Initialize MIDI channel volume properly.Johannes Schickel
This fixes bug #3067148 "DRACI: Volume range not respected". It seems Draci's MIDI files do not setup the channel volume properly before using the channels, but rely on having the maxed out. Since formerly the channel volume was initialized to 255, it caused the channel volume to be zero in case the user used 128 for his volume settings (128*255/255=128, and MIDI volume goes from 0-127). svn-id: r52738
2010-09-15MIDI: Send a reset MIDI device signal on startup.Johannes Schickel
This is currently done in the engine code. I adapted AGI, AGOS, DRACI, GROOVIE, LURE, MADE, QUEEN, SAGA, SKY, TINSEL and TOUCHE to send a reset device on startup. The sound output still works fine (started up a game from every engine), so this should hopefully not introduce any regressions. As far as I can tell it seems that SCUMM does send a proper device reset, so I did not touch it. KYRA only sends a proper reset for MT-32 currently. I am not sure about SCI though. This fixes bug #3066826 "SIMON: MIDI notes off when using RTL after SCI". svn-id: r52736
2010-02-27DRACI: Don't try to set the volume for channels that couldn't be allocated ↵Jordi Vilalta Prat
(fixes bug #2907954: "DRAGON: Crash in Intro") svn-id: r48147
2010-01-12Rename all "Adlib" uses to "AdLib" to match the real name of the sound card ↵Johannes Schickel
/ company. Check this for reference: http://en.wikipedia.org/wiki/Ad_Lib,_Inc. http://www.crossfire-designs.de/images/articles/soundcards/adlib.jpg (note the upper left of the card) This commit does not touch "adlib" and "ADLIB" uses! Also it does not update all the SCUMM detection entries, which still use "Adlib". svn-id: r47279
2009-11-12Implemented "Mute All"Robert Špalek
svn-id: r45873
2009-11-08Updated the list of TODOsRobert Špalek
svn-id: r45768
2009-10-30Fixed svn:keywordsRobert Špalek
svn-id: r45523
2009-10-26fix free/deleteRobert Špalek
svn-id: r45422
2009-10-26Fix 2 MIDI bugsRobert Špalek
svn-id: r45392
2009-10-22Implemented GPL2 commands for music.Robert Špalek
Debugged everything. svn-id: r45330
2009-10-22Fix uninitialized channel volumes.Robert Špalek
This fixed stopped music after calling the configuration dialog. svn-id: r45327
2009-10-22Improved music handling:Robert Špalek
- reading the volume from the configuration - error handling of non-existent MIDI files - pausing/resuming music unfortunately, sometimes music stops playing or slows down, and my log messages have so far not helped me to identify why svn-id: r45326
2009-10-21Enabled music.Robert Špalek
Several TODO's added. svn-id: r45298
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-06 00:37:19 +0000