Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
|
|
cce851d1af introduced a check to allow only static ani objects. However
after this change, only part of the pipes for vertical movement were
interactive.
This change aims to restore functionality for the other object types
while still preventing the invalid casts.
|
|
I am not entirely sure this is a correct fix for these leaks;
there is still the issue of the last member of _dynamicPhases being
invalidated and not removed sometime before the destruction of
Movement. Also, some of the items in this array are not actually
owned by Movement so deleting them will cause double-frees or
use-after-frees. It may be the case that a second list should be
maintained instead containing only the objects that are created
internally within Movement. Further testing will tell for sure.
|
|
|
|
|
|
|
|
and Sc2
|
|
|
|
|
|
|
|
|
|
statics, remove unnecessary Picture allocation
|
|
|
|
graphics code
|
|
|
|
|
|
|
|
|
|
Thanks to wjp for the suggestion
|
|
Free the pixel data of each entry in the _dynamicPhases array before
emptying it
|
|
The TODO in the code in question should be reviewed, but the call to
freePixelData() unconditionally deleted the original bitmap, which is
not correct
|
|
|
|
|
|
|
|
|
|
|
|
There are several calls to loadFile() with _memfilename, which is why
these two changes are interconnected
|
|
|
|
Fixes part of bug #9654.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
constructor
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|