Age | Commit message (Collapse) | Author |
|
|
|
The regression affected AGOS and maybe some others; specifically,
the real MidiDriver would have been deleted twice -- I previously
missed that the Engine instances takes care of freeing the real
MidiDriver, not the MidiPlayer wrapping it.
This commit should clarify the ownership of the real MidiDriver for
most pseudo MidiDrivers.
|
|
Many engines follow the advice in audio/midiparser.h and create a
"pseudo-MidiDriver" subclass. But MidiParser really only needs a tiny
subset of the MidiDriver capabilities, namely those found in
MidiDriver_BASE. So we try to subclass from that whenever possible; this
allows us to remove many stub methods, and enables further future
simplifications.
|
|
This in turn enables modifying MidiDriver_MPU401::close() to allow
it to be called on a midi driver that has not yet been opened.
The specific issue that triggered me to make these changes was a
crash-upon-quit in HUGO, caused by it instantiating a midi driver,
then encountering an error (missing hugo.dat) *before* having
opened the new midi driver; the general cleanup code then tries
to close the (not yet opened) midi driver -> kaboom
Also fixed some engines which were leaking MidiDriver instances.
|
|
|
|
svn-id: r55850
|
|
svn-id: r50163
|
|
- Rewritten T7G's font code to subclass Graphics::Font and make it cleaner.
- Use theme fonts for the Mac version of T7G (which used ugly system fonts
originally). With this the Mac version should be completable.
- Cleanup include interdependencies.
svn-id: r49487
|
|
svn-id: r45616
|
|
audio playback on engine quit. (This only problem affected playback from CD, not from ripped audio files)
svn-id: r43512
|
|
partway through a video
svn-id: r43068
|
|
- Added an empty MusicPlayerMac to let the Macintosh version of The 7th Guest start
svn-id: r42116
|
|
- Add some 11H opcodes
svn-id: r39313
|
|
2474078, but might break other things so I'm not going to backport it.
svn-id: r36125
|
|
svn-id: r35792
|
|
svn-id: r35656
|
|
svn-id: r35440
|
|
play by ripping it as track 2 (not tested).
svn-id: r35167
|
|
svn-id: r35166
|
|
unpredictable crashes I've been seeing.
svn-id: r35116
|
|
svn-id: r35060
|