Age | Commit message (Collapse) | Author |
|
|
|
MKID_BE relied on unspecified behavior of the C++ compiler,
and as such was always a bit unsafe. The new MKTAG macro
is slightly less elegant, but does no longer depend on the
behavior of the compiler.
Inspired by FFmpeg, which has an almost identical macro.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This more or less silently fixes the silent music introduced with f19e201, by
me setting volume to "true" instead of "255". Whoops.
|
|
|
|
|
|
|
|
Found by GCC 4.6's -Wunused-but-set-variable
|
|
Many engines follow the advice in audio/midiparser.h and create a
"pseudo-MidiDriver" subclass. But MidiParser really only needs a tiny
subset of the MidiDriver capabilities, namely those found in
MidiDriver_BASE. So we try to subclass from that whenever possible; this
allows us to remove many stub methods, and enables further future
simplifications.
|
|
This in turn enables modifying MidiDriver_MPU401::close() to allow
it to be called on a midi driver that has not yet been opened.
The specific issue that triggered me to make these changes was a
crash-upon-quit in HUGO, caused by it instantiating a midi driver,
then encountering an error (missing hugo.dat) *before* having
opened the new midi driver; the general cleanup code then tries
to close the (not yet opened) midi driver -> kaboom
Also fixed some engines which were leaking MidiDriver instances.
|
|
This fixes an out of bounds write introduced with 9216c7e.
|
|
master
Conflicts:
backends/platform/android/android.cpp
engines/sci/graphics/screen.cpp
engines/sci/graphics/transitions.cpp
|
|
This avoids a dialog about MT-32 to General MIDI conversion shown when running
Kyrandia 1. Formerly the NULL MIDI output type was set to General MIDI, which
caused the aforementioned dialog to show up, because Kyrandia 1 has no General
MIDI tracks.
|
|
|
|
This fixes a bug when loading savegames with different active hand items via GMM. The mouse cursor was not set to the active hand item in these cases.
|
|
|
|
Engine::runDialog.
svn-id: r55864
|
|
svn-id: r55863
|
|
svn-id: r55850
|
|
svn-id: r55818
|
|
svn-id: r55806
|
|
svn-id: r55623
|
|
svn-id: r55620
|
|
svn-id: r55619
|
|
svn-id: r55618
|
|
svn-id: r55039
|
|
svn-id: r54815
|
|
svn-id: r54716
|
|
svn-id: r54385
|
|
svn-id: r54358
|
|
Only changed this in engines where 'color' was/is already used
almost exclusively
svn-id: r54288
|
|
svn-id: r54148
|
|
This commit contains the AudioCDManager changes from the gsoc2010-opengl
branch. The other changes in that branch are restricted to the backends
directory only (plus configure).
The Nintendo DS and Dreamcast ports still need to be ported over to
the new Audio CD system, but that should be fairly easy to do.
svn-id: r54147
|
|
svn-id: r54132
|
|
* names now comply to our naming conventions
* the function computeStreamMD5AsString which computes the MD5
as a hex string now returns it as a Common::String
* add doxygen comments
svn-id: r54121
|
|
svn-id: r54105
|
|
svn-id: r54032
|
|
svn-id: r54007
|
|
This is a first step towards getting rid of all uses of regular printf,
fprintf, vprintf, vfprintf, puts, fputs, etc. in our codebase.
The name format() reflects the purpose of the function, and parallels
String.format() in Java, boost::format, and others.
svn-id: r54004
|
|
(Crash in Yvel tavern basement)
svn-id: r53973
|
|
(Vaelan's Cube can be duplicated at Scotia's Barrier)
This is a bug in the game data of early unpatched floppy versions.
This can also be fixed by applying the official patch (ftp://ftp.westwood.com/pub/lands1/updates/lolus123.exe).
svn-id: r53954
|
|
(Last commit got trunkated somehow)
svn-id: r53927
|
|
(Users will get AdLib music at default unless they have specified a MIDI device in the launcher (MT-32 for KYRA, GM for HOF and LOL.)
svn-id: r53926
|
|
svn-id: r53915
|
|
This is to avoid name similarity between KyraEngine::saveGameState(Intern)
and Engine::saveGameState.
svn-id: r53912
|