aboutsummaryrefslogtreecommitdiff
path: root/engines/kyra
AgeCommit message (Collapse)Author
2018-05-06KYRA: Mark always-false condition as TODOAdrian Frühwirth
2018-05-05ALL: Use CLIP to clip volumesAdrian Frühwirth
2018-04-19JANITORIAL: Fix whitespaceAdrian Frühwirth
2018-04-07ALL: Load savegame thumbnail only when necessaryAdrian Frühwirth
This commit introduces the following changes: 1. Graphics::loadThumbnail() Now returns a boolean and takes a new argument skipThumbnail which defaults to false. In case of true, loadThumbnail() reads past the thumbnail data in the input stream instead of actually loading the thumbnail. This simplifies savegame handling where, up until now, many engines always read the whole savegame metadata (including the thumbnail) and then threw away the thumbnail when not needed (which is in almost all cases, the most common exception being MetaEngine::querySaveMetaInfos() which is responsible for loading savegame metadata for displaying it in the GUI launcher. 2. readSavegameHeader() Engines which already implement such a method (name varies) now take a new argument skipThumbnail (default: true) which is passed through to loadThumbnail(). This means that the default case for readSavegameHeader() is now _not_ loading the thumbnail from a savegame and just reading past it. In those cases, e.g. querySaveMetaInfos(), where we actually are interested in loading the thumbnail readSavegameHeader() needs to explicitely be called with skipThumbnail == false. Engines whose readSavegameHeader() (name varies) already takes an argument loadThumbnail have been adapted to have a similar prototype and semantics. I.e. readSaveHeader(in, loadThumbnail, header) now is readSaveHeader(in, header, skipThumbnail). 3. Error handling Engines which previously did not check the return value of readSavegameHeader() (name varies) now do so ensuring that possibly broken savegames (be it a broken thumbnail or something else) don't make it into the GUI launcher list in the first place.
2018-03-28KYRA: Add method override statementsEugene Sandulenko
2017-12-26LOL: Fix detection entry for LOL Japanese (Bug #9828)Matan Bareket
2017-12-26KYRA: Added detection entries for LOL Japense PC9821 version - Bug #9828Matan Bareket
2017-12-26KYRA: Added detection entries for LOL German version - Bug #9557Matan Bareket
2017-12-26KYRA: Added detection entries for LOL Chinese Floppy version - Bug #7893Matan Bareket
2017-12-26KYRA: Added detection entries for LOL Spanish Floppy version - Bug #9699Matan Bareket
2017-11-10Merge pull request #1041 from criezy/variadic-undefinedThierry Crozat
Fix undefined behaviour in variadic functions
2017-10-07ENGINES: Remove default1x scaler flagColin Snover
This flag is removed for a few reasons: * Engines universally set this flag to true for widths > 320, which made it redundant everywhere; * This flag functioned primarily as a "force 1x scaler" flag, since its behaviour was almost completely undocumented and users would need to figure out that they'd need an explicit non-default scaler set to get a scaler to operate at widths > 320; * (Most importantly) engines should not be in the business of deciding how the backend may choose to render its virtual screen. The choice of rendering behaviour belongs to the user, and the backend, in that order. A nearby future commit restores the default1x scaler behaviour in the SDL backend code for the moment, but in the future it is my hope that there will be a better configuration UI to allow users to specify how they want scaling to work for high resolutions.
2017-10-06KYRA: Fix undefined behaviour in variadic functionsThierry Crozat
Passing a type that undergoes default argument promotion as last argument of a variadic function results in undefined behaviour.
2017-08-06JANITORIAL: Silence more GCC 7 warningsTorbjörn Andersson
All these fall through were marked as deliberate, so again I've only changed the comment to silence GCC.
2017-07-27VIDEO: Allow setting the mixer sound type used to play audio tracksBastien Bouclet
2016-12-08ALL: Leave out instructions for engine data issuesBen Castricum
2016-12-06ALL: replace 2 more 'download engine data' instructionsBen Castricum
2016-11-29ALL: save file => saved gameBen Castricum
2016-11-29ALL: game state => saved gameBen Castricum
2016-11-26KYRA: Update POTFILESrootfather
2016-10-31JANITORIAL: TyposAlexandre Detiste
I've not fixed this one, maybe it's on purpose: RELASE -> RELEASE engines/mads/staticres.cpp:const char *const kGameReleaseTitleStr = "GAME RELASE VERSION INFO";
2016-10-25KYRA: (LOL) Fix buffer overflow in _lastOverridePalFileWillem Jan Palenstijn
It was storing filenames of length 12 in a char[12] buffer. Fixes bug #9627.
2016-09-18ALL: Homogeneize use of 'saved game' in messagesThierry Crozat
2016-08-30Merge pull request #788 from Tkachov/cloudEugene Sandulenko
ALL: Add Cloud storage support
2016-08-27KYRA: (LOL) - fix #7183 (LOL-CD: game crashes and exits when ↵athrxx
looking/picking item)
2016-08-24ALL: Make simpleSaveNames() a MetaEngineFeatureAlexander Tkachev
Added it into hasFeature() of all engines which returned `true` in simpleSaveNames() before. As mentioned in #788, SCI is not always using simple names, so it doesn't have such feature now.
2016-08-24KYRA: Fix openSaveForWriting() to return OutSaveFileAlexander Tkachev
2016-08-24CLOUD: Make OutSaveFile start saves syncAlexander Tkachev
It had to become a proxy class in order to do that. finalize() starts the saves sync.
2016-08-24ALL: Add MetaEngine::simpleSaveNames()Alexander Tkachev
Engines with "simple" savenames would support "Run in background" in save/load dialog and gradual save slots unlocking. Other engines save/load feature would be locked until save sync is over.
2016-07-30KYRA: Bump kyra.dat version for updated Italian EOB1 changesEugene Sandulenko
2016-05-17KYRA: Remove redundant code.Eugene Sandulenko
item variable value is less than 33, that is, 32 max. item+1 is never > 33. Thus, the clapping code is redundant.
2016-05-15KYRA: Simplify Kyra1 audio track filename handlingJohannes Schickel
2016-05-15Revert "KYRA: Plug memory leak"Johannes Schickel
This reverts commit 9909cc615d527bc8d43f930d8c88dc014974f2de. This will likely cause invalid memory reads because it frees the last output buffer which is used to keep files in memory. There is a possible memory leak here, when the input data is not well formed. However, fixing this takes some more effort than the solution in the reverted commit.
2016-05-15KYRA: Silence analysis tools about possible memory leaksJohannes Schickel
2016-05-15Revert "KYRA: Plug memory leak"Johannes Schickel
This reverts commit c22ca8ffb515b03712a0f0e36dd40c7e38c4b8ed. This revision caused invalid memory reads in Kyra1 DOS+FM-TOWNS.
2016-05-15KYRA: Plug memory leakEugene Sandulenko
2016-05-15KYRA: Plug memory leakEugene Sandulenko
2016-04-15KYRA: Initialize variable before usage.Johannes Schickel
Thanks to salty-horse for reporting.
2016-04-14JANITORIAL: Reduce audio header dependenciesOri Avtalion
2016-04-14JANITORIAL: Reduce GUI header dependenciesOri Avtalion
2016-04-03KYRA: (LOL) fix bug #7104 (LOL-CD: mixing sfx and voice mode does not work)athrxx
2016-03-13BACKENDS: Only expose one set of functions for AudioCDManagerMatthew Hoops
Engines should only have to call one set of functions and not decide between the two. In fact, the 'emulation' API was documented to just call the 'real CD' API.
2016-03-13KYRA: Ensure openCD() is calledMatthew Hoops
2016-02-27KYRA: Formatting fixes.Johannes Schickel
2016-02-27KYRA: Remove ADGF_TESTING from EoB 1+2.Johannes Schickel
2016-02-25KYRA: Let listSaves return list sorted on slot numbers.Johannes Schickel
2016-02-15JANITORIAL: Typos detected with lintian & grepAlexandre Detiste
2016-02-09KYRA: Run astyle on sound.cpp.Johannes Schickel
2016-01-26KYRA: Cleanup listing of actual save slots in GUI::updateSaveFileList.Johannes Schickel
2016-01-26KYRA: Only request actual save slots in listSaves.Johannes Schickel