Age | Commit message (Collapse) | Author |
|
|
|
The regression affected AGOS and maybe some others; specifically,
the real MidiDriver would have been deleted twice -- I previously
missed that the Engine instances takes care of freeing the real
MidiDriver, not the MidiPlayer wrapping it.
This commit should clarify the ownership of the real MidiDriver for
most pseudo MidiDrivers.
|
|
Many engines follow the advice in audio/midiparser.h and create a
"pseudo-MidiDriver" subclass. But MidiParser really only needs a tiny
subset of the MidiDriver capabilities, namely those found in
MidiDriver_BASE. So we try to subclass from that whenever possible; this
allows us to remove many stub methods, and enables further future
simplifications.
|
|
This in turn enables modifying MidiDriver_MPU401::close() to allow
it to be called on a midi driver that has not yet been opened.
The specific issue that triggered me to make these changes was a
crash-upon-quit in HUGO, caused by it instantiating a midi driver,
then encountering an error (missing hugo.dat) *before* having
opened the new midi driver; the general cleanup code then tries
to close the (not yet opened) midi driver -> kaboom
Also fixed some engines which were leaking MidiDriver instances.
|
|
svn-id: r55850
|
|
svn-id: r51101
|
|
property paragraph)
svn-id: r47489
|
|
svn-id: r47396
|
|
svn-id: r45616
|
|
Fixed issues with quitting and calling GMM during intro sequences in LURE. Added a KEYCODE_MAINMENU in common/keyboard.h for the GMM.
svn-id: r33081
|
|
svn-id: r32857
|
|
svn-id: r32855
|
|
svn-id: r31419
|
|
svn-id: r31194
|
|
svn-id: r30664
|
|
headers are consistant with the other files
svn-id: r30433
|
|
svn-id: r30238
|
|
two different classes, use the value in SoundManager instead. As a consequence
the engine now remaps the instruments from MT-32 to General MIDI for me, since
isRoland() is true and hasNativeMT32() is false. Earlier, it didn't since the
uninitialised _nativeMT32 happened to be true for me.
svn-id: r29878
|
|
added code from the original game that used the high bit of sounds to distinguish between the two
svn-id: r29873
|
|
restorable are restarted after loading a savegame)
svn-id: r29271
|
|
svn-id: r29114
|
|
svn-id: r28917
|
|
svn-id: r28545
|
|
svn-id: r27604
|