| Age | Commit message (Collapse) | Author |
|---|
|
This commit introduces the following changes:
1. Graphics::loadThumbnail()
Now returns a boolean and takes a new argument skipThumbnail which
defaults to false. In case of true, loadThumbnail() reads past the
thumbnail data in the input stream instead of actually loading the
thumbnail. This simplifies savegame handling where, up until now,
many engines always read the whole savegame metadata (including
the thumbnail) and then threw away the thumbnail when not needed
(which is in almost all cases, the most common exception being
MetaEngine::querySaveMetaInfos() which is responsible for loading
savegame metadata for displaying it in the GUI launcher.
2. readSavegameHeader()
Engines which already implement such a method (name varies) now take
a new argument skipThumbnail (default: true) which is passed
through to loadThumbnail(). This means that the default case for
readSavegameHeader() is now _not_ loading the thumbnail from a
savegame and just reading past it. In those cases, e.g.
querySaveMetaInfos(), where we actually are interested in loading
the thumbnail readSavegameHeader() needs to explicitely be called
with skipThumbnail == false.
Engines whose readSavegameHeader() (name varies) already takes an
argument loadThumbnail have been adapted to have a similar
prototype and semantics.
I.e. readSaveHeader(in, loadThumbnail, header) now is
readSaveHeader(in, header, skipThumbnail).
3. Error handling
Engines which previously did not check the return value of
readSavegameHeader() (name varies) now do so ensuring that possibly
broken savegames (be it a broken thumbnail or something else) don't
make it into the GUI launcher list in the first place.
|
|
In older releases of Myst the flyby video had the play on card change
flag set to true, causing the bug. As a workaround patch the resource to
mach newer releases.
Fixes #10472.
|
|
To make static analysis tools quiet.
|
|
Used when turning pages in the library. Some versions of the game appear
to use them.
Fixes #10474.
|
|
|
|
|
|
|
|
|
|
Otherwise the movie position is zero which leads the comparison with the
stored opcode position to always be false.
Fixes #10426, a regression from cf1171d4d9b43eba.
|
|
When videos are skipped, they would sometimes not quite be seeked to the
last frame. In that case, when they are played again without being
restarted, they would end immediatly.
Now videos are automatically rewinded when they end or are skipped so
that they always start from the beginning when played again.
Fixes #10389.
|
|
Those shortcuts are documented in the original game manual.
|
|
This fixes keyboard book page turning being too fast when holding keys
|
|
Fixes #10075
|
|
Fix undefined behaviour in variadic functions
|
|
|
|
|
|
This flag is removed for a few reasons:
* Engines universally set this flag to true for widths > 320,
which made it redundant everywhere;
* This flag functioned primarily as a "force 1x scaler" flag,
since its behaviour was almost completely undocumented and users
would need to figure out that they'd need an explicit non-default
scaler set to get a scaler to operate at widths > 320;
* (Most importantly) engines should not be in the business of
deciding how the backend may choose to render its virtual screen.
The choice of rendering behaviour belongs to the user, and the
backend, in that order.
A nearby future commit restores the default1x scaler behaviour in
the SDL backend code for the moment, but in the future it is my
hope that there will be a better configuration UI to allow users
to specify how they want scaling to work for high resolutions.
|
|
Passing a type that undergoes default argument promotion as last
argument of a variadic function results in undefined behaviour.
|
|
Fixes the per frame scripts being leaked.
Fixes #10215.
|
|
Fixes #10216.
|
|
|
|
|
|
Fixes #10114.
|
|
Thanks to dafioram for providing the replacement image.
Fixes #10115.
|
|
|
|
Fixes #10118.
|
|
It was due to inaccurate rotation movie bounds.
Fixes #10086.
|
|
Fixes #10065.
|
|
Fixes #10064
|
|
Fixes #10103.
|
|
Fixes #10108.
|
|
When using keyboard navigation
|
|
One call to va_end was missing when returning early. This stuff is too
dangerous for me to use.
|
|
Fixes #10081.
|
|
|
|
The Steam version is a DVD version, but also has files from the CD
version in the data folder. We need to load only the files from the DVD
version to prevent data inconsistencies.
Also check on startup that all the required datafiles are present.
Possibly fixes #10052.
|
|
Fixes #10063.
|
|
|
|
Those are obviously repackaged CD versions
|
|
|
|
Fixes #10053.
|
|
The animation is too slow when displaying each frame at 60 fps.
Fixes #10053
|
|
Also simplify video filename construction.
|
|
Prevents the quit confirmation dialog from being displayed at the end of
the game's ending if it is enabled.
Fixes #9943.
|
|
Fixes #9938.
|
|
This was breaking builds with the Myst sub-engine disabled.
|
|
The new screen update strategy does not allow scripts to draw twice at
the same location for blinking.
|
|
The game was trying to start playing the linking book video in a
blocking way whereas it was set to loop by the first check.
Fixes #9914.
|
|
|
|
|
