aboutsummaryrefslogtreecommitdiff
path: root/engines/sci/graphics
AgeCommit message (Collapse)Author
2014-01-15ALL: Remove optimization unstable code on checking for null after new.D G Turner
These issues were identified by the STACK tool. By default, the C++ new operator will throw an exception on allocation failure, rather than returning a null pointer. The result is that testing the returned pointer for null is redundant and _may_ be removed by the compiler. This is thus optimization unstable and may result in incorrect behaviour at runtime. However, we do not use exceptions as they are not supported by all compilers and may be disabled. To make this stable without removing the null check, you could qualify the new operator call with std::nothrow to indicate that this should return a null, rather than throwing an exception. However, using (std::nothrow) was not desirable due to the Symbian toolchain lacking a <new> header. A global solution to this was also not easy by redefining "new" as "new (std::nothrow)" due to custom constructors in NDS toolchain and various common classes. Also, this would then need explicit checks for OOM adding to all new usages as per C malloc which is untidy. For now to remove this optimisation unstable code is best as it is likely to not be present anyway, and OOM will cause a system library exception instead, even without exceptions enabled in the application code.
2013-12-26SCI: fix sci1early+ ega picture issuesMartin Kiewitz
also remove hacks for kq5ega + sq4ega
2013-12-26SCI: floodfill reverted, was sci1early differenceMartin Kiewitz
fixes sq4 floppy properly
2013-12-24SCI: portraits cleanup + show base picture at endMartin Kiewitz
2013-12-24SCI: injecting "dual" view into King's Quest 6 CDMartin Kiewitz
for dual mode (text+speech at the same time)
2013-12-24SCI: injecting "dual" view into Laura Bow 2 CDMartin Kiewitz
for dual mode (text+speech at the same time)
2013-12-24SCI: change floodfill fix for sq4Martin Kiewitz
behaviour wasn't changed in SCI1, instead it seems that SSCI draws overlays to separate memory and then copies them over. Previous commit caused regression in qfg1vga (funny room)
2013-12-23SCI: change floodfill to fix sq4 ship taking offMartin Kiewitz
fixes bug #6446
2013-12-18SCI: debug code to print out kq6 raw lipsync dataMartin Kiewitz
2013-12-11SCI: rave support (KQ6 hires portrait lip sync)Martin Kiewitz
Thanks to wjp and [md5] for helping
2013-12-10SCI: Add handling for the RAVE resource type, found in KQ6CDFilippos Karapetis
This contains the sync data in the Windows version of KQ6CD. Note that currently the sync36 resource is 2 bytes bigger (it contains 2 bytes from the RAVE resource). Some test code has also been added to dump the RAVE sync resources
2013-10-02SCI: Make a note about pic 390 in the blacklisted SQ4CD NRS patch 1.2Filippos Karapetis
2013-09-21SCI: fix for heap corruption during lsl3 endingm-kiewitz
2013-08-19SCI: Fix bug #3614914 - "SCI: Castle of Dr Brain Spanish crashes after ↵Filippos Karapetis
Computer Room" Ignore the unused x/y displacement fields of cels embedded in pics. Dr. Brain Spanish, pic 261 contains garbage in these fields (probably left overs)
2013-08-03SCI: Take advantage of Surface::getPixels.Johannes Schickel
2013-08-03SCI: Prefer getBasePtr over direct Surface::pixels access.Johannes Schickel
2013-07-30SCI: Add a hack to fix the inventory in GK1Filippos Karapetis
For some reason, the top left nsRect coordinates get swapped in the GK1 inventory screen, investigate why
2013-07-14JANITORIAL: Remove trailing whitespaceSven Hesse
2013-06-21SCI: Avoid using g_sci for usesOldGfxFunctions() in the GfxPorts classFilippos Karapetis
2013-05-01SCI: Fix a non-initialized variable in GfxScreen - CID 1003105Filippos Karapetis
2013-05-01SCI: Fix a non-initialized variable in GfxCursor - CID 1003112Filippos Karapetis
2013-05-01SCI: Fix a non-initialized variable in GfxControls16 - CID 1003114Filippos Karapetis
2013-05-01SCI: Fix a non-initialized variable in GfxMenu - CID 1003110Filippos Karapetis
2013-05-01SCI: Initialize some members of GfxPaint16 - CID 1010057Filippos Karapetis
2013-04-28SCI: Change wording for the cursor position workaroundsFilippos Karapetis
2013-04-27SCI: Change wording for bug/further info referencesFilippos Karapetis
2013-04-25SCI: Fix scaling in the back room of the bookstore in GK1Filippos Karapetis
2013-04-18SCI: Remove a bunch of unused private member variablesMax Horn
All instances uncovered by clang warnings.
2013-04-16SCI: Fix potential memory leak with Mac cursor's hotspotMatthew Hoops
2013-04-16SCI: Fix mac cursor memory leakMatthew Hoops
2013-04-15SCI: Fix hunk entry leakWillem Jan Palenstijn
2013-03-28SCI: Fix drawing in SCI21 hires games without breaking lowres SCI2/SCI21 gamesFilippos Karapetis
2013-02-23ALL: Fix typo (existant->existent)Willem Jan Palenstijn
2013-01-13SCI: Some more work on scaling in SCI32Filippos Karapetis
2013-01-11SCI: Fix the night time palette in QFG4Filippos Karapetis
2013-01-11SCI: More proper handling of scaling and global scaling in SCI32Filippos Karapetis
This fixes several scaling related problems in QFG4 and SQ6
2013-01-11SCI: Remove obsolete comment and codeFilippos Karapetis
2013-01-11SCI: Disable modification of object NS rects in SCI32Filippos Karapetis
This fixes the sliders in QFG4 without introducing any regressions, as the objects are still drawn on screen using the per-frame adjusted coordinates
2012-11-26SCI: Amended fix for palette related compiler warnings.D G Turner
2012-11-26SCI: Fix warningsFilippos Karapetis
2012-11-15SCI: Properly reset the palVary signal when loading (bug #3575569)Filippos Karapetis
2012-11-07SCI: Fix bug #3575569 - "SCI: QFG1VGA: Palette/hue bug after loading"Filippos Karapetis
We make sure that any leftover palVary timers are removed when loading. This is an edge case, but it won't hurt to remove these timers just in case
2012-10-08SCI: Add a workaround for the large text boxes in Freddy Pharkas CDFilippos Karapetis
Fixes bug #3575276 - "SCI: Freddy Pharkas: Text sometimes drawn/erased incorrectly"
2012-09-26JANITORIAL: Remove trailing whitespaces.Johannes Schickel
Powered by: git ls-files "*.cpp" "*.h" "*.m" "*.mm" | xargs sed -i -e 's/[ \t]*$//'
2012-08-26Merge pull request #268 from clone2727/video-rewriteMatthew Hoops
VideoDecoder upgrade & partial rewrite
2012-08-21SCI: Update a commentFilippos Karapetis
2012-08-21SCI: More work on kRemapColorsFilippos Karapetis
This implements some more color remap-based palette effects, found in QFG4
2012-08-16VIDEO: Remove setSystemPalette()Matthew Hoops
2012-07-26SCI: Differentiate between screen width and pitchFilippos Karapetis
This properly addresses the odd screen width (630) in Phantasmagoria 1
2012-07-25SCI: Fix delete[] formatting.Johannes Schickel