aboutsummaryrefslogtreecommitdiff
path: root/engines/sci
AgeCommit message (Collapse)Author
2018-03-28SCI: Added overried specifiersEugene Sandulenko
2018-03-23JANITORIAL: Silence GCC warningAdrian Frühwirth
2018-03-23JANITORIAL: Silence GCC 7 fallthrough warningAdrian Frühwirth
This wasn't explicitly marked as intentional but it very much looks it. Committing separately in the unlikely case this needs to be reverted.
2018-02-01SCI: Avoid (false positive) uninitialized use warningWillem Jan Palenstijn
2018-02-01SCI: Sabotage qfg1vga's speed testWillem Jan Palenstijn
This ensures the detected speed will end up at the highest level. This improves the detail in Yorick's room (96), and slightly changes the timing in other rooms. Fixes bug #10296.
2018-01-31COMMON: Move VER macro for serializer into common codeColin Snover
2018-01-30SCI: Add detection entry for LB2 ES floppyColin Snover
Fixes Trac#10416.
2018-01-16SCI32: Fix PQ4 Barbie shoe points patch selectorDavid Fioramonti
The original script patch had the correct literal value but the wrong selector name in the comment for the literal value, so when it was converted to use a selector lookup in c5dce17b1f1392feb8825aba5addbc3999eeaa51, the patch broke because the wrong selector name was used. Fixes Trac#10392. Closes gh-1107.
2018-01-02SCI32: Fix segfault when SCI3 vocab isn't foundDan Church
Seen when attempting to detect and/or run the Shivers 2 demo. Closes gh-1106.
2017-12-26SCI: Added detection entries for Lighthouse German version - Bug #10359Matan Bareket
2017-12-26SCI: Added detection entries for SQ1 Russian version - Bug #10156Matan Bareket
2017-12-26SCI: Added detection entries for PQ2 English version 1.002.011 - Bug #9716Matan Bareket
2017-12-19SCI32: Add uninitialized read workaround for LSL6hiresColin Snover
Fixes Trac#10361.
2017-12-03SCI: Avoid buffer overflow in amigamac sound driverWillem Jan Palenstijn
By default, frac_t is interpreted as signed. The resulting range isn't large enough to store offsets, so we interpret it as unsigned here instead. Fixes a crash in QfG1/Mac where instrument->loop_size is 49457.
2017-12-01SCI: Partially clean up SCI16 video playback codeColin Snover
2017-11-28SCI32: Fix crash starting KQ7 demoColin Snover
Fixes Trac#10343.
2017-11-23SCI32: Remove ADGF_TESTING flags for releaseColin Snover
2017-11-19SCI32: Add Phantasmagoria IT detection entryColin Snover
Fixes Trac#10157.
2017-11-19SCI32: Add KQ7 1.51 FR detection entryColin Snover
Fixes Trac#10301.
2017-11-19SCI: Fix UB shifting negative integersColin Snover
2017-11-11SCI32: Fix integer overflow calculating audio durationColin Snover
Due to the need to calculate the audio duration with millisecond precision from the file size, it is possible to overflow a 32-bit integer in games with long background audio loops, like RAMA, during the calculation of the duration. It is also not necessary to give some framerate here, so eliminate the unnecessary explicit Timestamp construction with the second argument.
2017-10-29SCI: Fix UB in SegManager memcpy/strcpy operationsColin Snover
Passing overlapping buffers to C standard library memcpy, strcpy, and strncpy is undefined behavior. In SSCI these operations would perform a forward copy, and most stdlib implementations do the same, but at least newer Linux glibc on x86 copies bytes in reverse, so just using the standard library on this platform results in broken output. Because SSCI used a blind forward copy instead of memmove for overlapping copy operations, this patch implements an explicit forward copy to ensure that overlapping copies continue to operate the same as in SSCI. This fixes the Island of Dr. Brain v1.1 flamingo puzzle (script 185, flamingos::init, localCall 4c3) on platforms that do not perform forward copy in memcpy/strcpy/strncpy. Thanks to @moralrecordings for research on this bug and an initial patch using memmove. Closes gh-1034.
2017-10-21SCI: Allow lofsa string printing in disasm for all SCI versionsWillem Jan Palenstijn
2017-10-21SCI: Fix offsets in disasm for multi-param opcodesWillem Jan Palenstijn
This code was assuming that retval points to the start of the next instruction, which is only true if the current parameter is the last one. This fixes op_call printing.
2017-10-16SCI32: Fix cursor color when quitting for phant1David Fioramonti
When quitting the game at the main menu and hitting no or quitting the game while playing the cursor color over the buttons will be tan the first time rather than red. This fix makes it so it will be red. This was done by removing a check in HotSpot::doit() which checks the global193 value. Removing this check fixes the problem. Fixes Trac#9977. Thanks snover and wjp for your help.
2017-10-15SCI32: Tell OSystem to show/hide cursors as appropriateColin Snover
This is needed so that the system cursor can be appropriately hidden outside the game's draw area, to match the normal behaviour of ScummVM.
2017-10-08SCI32: Fix crash restoring save from endgame of RAMAColin Snover
Fixes Trac#10263.
2017-10-09SCI: Add QfG4 script patch to fix sliding down slope bug #9801Martin Kiewitz
It's quite difficult to patch. I hope this finally solved it.
2017-10-08SCI: Crazy Nick's Larry workaround bug #10184Martin Kiewitz
Added this already through last commit by accident Was supposed to get added by this. Workaround for reading uninitialized temp game bug.
2017-10-08SCI: Restrict some workarounds to certain tempsMartin Kiewitz
Also add a bit more documentation / Fix some documentation
2017-10-07SCI: Change index inside workaround tables to an index rangeMartin Kiewitz
So that one can specify an entire range of temp variables by using just one single entry.
2017-10-07SCI: Use explicit indexes in castlebrain/islandbrain word search workaroundsColin Snover
2017-10-07SCI: Add workaround for uninitialized reads in Island of Dr BrainColin Snover
Leaning on the enter key during a word search puzzle will trigger this bug, just like in Castle of Dr Brain.
2017-10-07ENGINES: Remove default1x scaler flagColin Snover
This flag is removed for a few reasons: * Engines universally set this flag to true for widths > 320, which made it redundant everywhere; * This flag functioned primarily as a "force 1x scaler" flag, since its behaviour was almost completely undocumented and users would need to figure out that they'd need an explicit non-default scaler set to get a scaler to operate at widths > 320; * (Most importantly) engines should not be in the business of deciding how the backend may choose to render its virtual screen. The choice of rendering behaviour belongs to the user, and the backend, in that order. A nearby future commit restores the default1x scaler behaviour in the SDL backend code for the moment, but in the future it is my hope that there will be a better configuration UI to allow users to specify how they want scaling to work for high resolutions.
2017-10-07SCI: Improve Larry 1 Spanish script patchMartin Kiewitz
So that it also works even when the patch files are missing.
2017-10-07SCI: Add script patch for Larry 1 Spanish bug #10240Martin Kiewitz
Fixes buying an apple from man wearing a barrel, who walks around in front of the casino.
2017-10-07Revert "SCI: Add workaround for uninitialized reads in Island of Dr Brain"Martin Kiewitz
This reverts commit ae8e4fa8e95f3ae347dfc681330bccc0b09d1f01. This change is wrong in any case. It should be specific to temp 14+15 at the very least. I also did not get an answer on what is actually happening internally. That's not how we should add workarounds. My review was also still pending.
2017-10-07SCI: Add workaround for uninitialized reads in Island of Dr BrainColin Snover
Leaning on the enter key during a word search puzzle will trigger this bug, just like in Castle of Dr Brain.
2017-10-07SCI: Add workaround for uninit read during wordsearch in castlebrainDavid Fioramonti
During the wordsearch puzzle (room 320 click left door) the game will crash because of an uninitalized read of temp variables in word::dispatchEvent (which gets called a lot), if the player clicks the same letter or different letters aggressively or holds down the enter key. Fixes Trac#9783.
2017-10-06SCI32: Clean up scriptWidth/scriptHeight/screenWidth/screenHeightColin Snover
This removes the unnecessary Buffer subclass and stops most places where the output buffer was being interrogated about dimensions instead of GfxFrameout.
2017-10-06SCI32: Rewrap comments to 80 columns in SOL decoderColin Snover
2017-10-06SCI32: Remove resolved TODO in helpers.hColin Snover
2017-10-06SCI32: Clean up script patch commentsColin Snover
2017-10-06SCI32: Clean up Robot decoderColin Snover
* Rewrap comments to 80 columns * Clarify comments where possible * Remove resolved TODOs
2017-10-06SCI32: Clean up CelObjColin Snover
* Rewrap comments to 80 columns * Clarify comments where possible * Use smart pointers where appropriate * Change view/pic flags detection to always use word-size (byte-size check for flag 0x80 was a compiler optimisation)
2017-10-06SCI32: Clean up GfxControls32Colin Snover
* Rewrap comments to 80 columns * Clarify comments where possible * Fix whitespace errors
2017-10-06SCI32: Rewrap comments to 80 columns in lists32.hColin Snover
2017-10-06SCI32: Clean up GfxPaint32Colin Snover
* Rewrap comments to 80 columns
2017-10-06SCI32: Clean up PlaneColin Snover
* Rewrap comments to 80 columns * Clarify comments where possible
2017-10-06SCI32: Clean up GfxRemap32Colin Snover
* Rewrap comments to 80 columns * Clarify comments where possible