aboutsummaryrefslogtreecommitdiff
path: root/engines
AgeCommit message (Collapse)Author
2010-04-12Revert "Fix use of "friend" keyword in KYRA for strict C++ compilers."Johannes Schickel
Actually g++ is just fine in this case :-). The thing I missed here was that I declared the "offending" classes as friends in subclasses of KyraEngine_v1, thus those friends were allowed to access the protected elements of KyraEngine_v1 too. svn-id: r48643
2010-04-12Fix use of "friend" keyword in KYRA for strict C++ compilers.Johannes Schickel
Unlike g++, which does inherit friends (it seems), C++ does specify that friend is not inherited. I.e. when B is a friend of A and you have a class C subclassing B, C is not allowed to access private memebers of A. svn-id: r48641
2010-04-12AUDIO: Rename Mixer::playInputStream to playStreamMax Horn
svn-id: r48637
2010-04-12Added the beginnings of the main timer listPaul Gilbert
svn-id: r48635
2010-04-11Apply patch #2984508 - "GSoC: SCUMM stopped audio from playing while saving"Ori Avtalion
This is a fix for bug #2090846 - "SCUMM: saving a game will play music before finishing" svn-id: r48630
2010-04-11Explain the rational of the CursorMan.pushCursor calls directlyMax Horn
Instead of referring to the commit log of a prior ref. Also rewrap some comments. svn-id: r48628
2010-04-11Setup and destroy a dummy cursor and palette in the Engine class.Johannes Schickel
The idea behind this is exactly the same as behind r48620, but it affects all engines, thus engine authors can now use CursorMan.replaceCursor without having to worry about possible memory leaks or the like. svn-id: r48626
2010-04-11Enable the cursor palette in ScummEngine_v70he::setDefaultCursor just to ↵Johannes Schickel
avoid problems in case it was disabled earlier. svn-id: r48622
2010-04-11Fix KYRA's cursor handling by pushing a dummy cursor via ↵Johannes Schickel
CursorMan.pushCursor too. Also replace CursorMan.popAllCursors by CursorMan.popCursor to prevent the caller's cursor from being destroyed. svn-id: r48621
2010-04-11Fix a memory leak in SCUMM which was caused by the SCUMM engine never ↵Johannes Schickel
removing its cursor from CursorMan. The problem here was that SCUMM only uses CursorMan.replaceCursor. When no cursor had been setup before it would cause the SCUMM cursor to be never removed from CursorMan, since in this case replaceCursor just uses pushCursor. To avoid this problem I am just pushing a dummy cursor (and palette, since that is used in SCUMM HE games too) on engine setup and removing it on engine destruction. Actually every engine should setup their first cursor via CursorMan.pushCursor and then on quit remove it again via CursorMan.popCursor. Using CursorMan.replaceCursor is *no* good idea for the first cursor to setup, since that might either replace an existing cursor, thus destroying the caller's cursor, or pushing a new cursor on the stack, which might result in a leak. This would also result in making a call to CursorMan.popCursor unsafe, since that might also impact the caller's cursor setup again. svn-id: r48620
2010-04-11Fix bug #2985387 "KYRA1: Crash at the end of game".Johannes Schickel
svn-id: r48617
2010-04-11Fix bug 2983187 on continuing palette changeRobert Špalek
svn-id: r48615
2010-04-09Remove unnecessary 'extern' keywordsOri Avtalion
svn-id: r48598
2010-04-08Remove unused dereferenceOri Avtalion
svn-id: r48586
2010-04-07fixed crash during time challenges (rclick without object)Vladimir Menshakov
svn-id: r48581
2010-04-07Add detection for an English ADI2 environment disk (for Amiga)Arnaud Boutonné
svn-id: r48580
2010-04-06Cleanup the Myst resource caching code a bit and add support for caching ↵Matthew Hoops
Myst ME MJMP sound 'jumps' svn-id: r48579
2010-04-06More transistions->transitions fixesMatthew Hoops
svn-id: r48571
2010-04-06Fix "Transitions" typoOri Avtalion
svn-id: r48570
2010-04-06Fix AdvancedMetaEngine::createInstance to use ConfMan.setBoolMax Horn
svn-id: r48568
2010-04-06Switch SaveStateDescriptor::getBool to use Common::parseBoolMax Horn
svn-id: r48567
2010-04-06GUI: Unify various definitions of kOKCmd and move it to namespace GUIMax Horn
svn-id: r48564
2010-04-06Factor out save/load code from MainMenuDialog::handleCommand into new methodsMax Horn
svn-id: r48563
2010-04-06SCUMM: Make HelpDialog & ConfigDialog internalMax Horn
svn-id: r48562
2010-04-06Remove old & undocumented MSVC 6 workaroundMax Horn
svn-id: r48561
2010-04-05Add support for 32bpp DirectBitsRect in Myst ME PICT's. Fixes various cards, ↵Matthew Hoops
especially in the Myst observatory. svn-id: r48558
2010-04-05Fix bug #2982014 "BASS: MT-32 warning on Intro skipping" by properly ↵Johannes Schickel
delaying the sysEx events. svn-id: r48536
2010-04-05Corrected check to ensure return isn't issued if it's already in progressPaul Gilbert
svn-id: r48535
2010-04-05Commit of the updated version of Fingolfin's patch for bug #2981788 "TINSEL: ↵Johannes Schickel
Build with -O2 broken". svn-id: r48534
2010-04-05Bugfix for correctly getting a follower to return to player when blocked ↵Paul Gilbert
from exiting a room 5 times svn-id: r48533
2010-04-05Application of patch #2981748 - Make VGA detection entries take precedence ↵Paul Gilbert
over EGA for command line detection svn-id: r48532
2010-04-04SCI: check before writing 0 in SegManager::strncpy, fixes jones/cd crashMartin Kiewitz
svn-id: r48519
2010-04-04SCI: put an ending NUL in strncpy, fixes castle of brain scrolling problem - ↵Martin Kiewitz
should be verified by the vm gurus (waltervn and lskovlun) svn-id: r48511
2010-04-04Fix bug #2960022 - PUTTPUTT 1: No Load/Save possible.Travis Howell
svn-id: r48499
2010-04-03Fix bug #2959947 - HE: Broken saves show in launcher.Travis Howell
svn-id: r48489
2010-04-03Disable the load from launcher button, in all games of Parallaction game engine.Travis Howell
svn-id: r48488
2010-04-03Fix bug #2976376 - NIPPON: Load from Launcher fails. By removing the ↵Travis Howell
kSupportsLoadingDuringStartup MetaEngineFeature flag (which was never supported). svn-id: r48485
2010-04-03Fix bug #2970141 - NIPPON: Crash at end of the game (regression). By ↵Travis Howell
reverting part of the changes to Parallaction_ns::cleanupGame() in revision 34939. svn-id: r48480
2010-04-02Fix whitespaceWillem Jan Palenstijn
svn-id: r48477
2010-04-02SCI: removing unused variable from palette::setMartin Kiewitz
svn-id: r48475
2010-04-02SCI: change actual setting of palette, fixes gk1 palette issue when talking ↵Martin Kiewitz
to grace indirectly caused by r47955, seems to also fix jones palette issue, could cause regressions svn-id: r48474
2010-04-02Fix bug #2969232 - NIPPON: Kos sprite broken (Regression). The current disk ↵Travis Howell
archive requires a higher priority, compared to the default disk archives. svn-id: r48469
2010-04-02Fix bug #2979193 - NIPPON: Crash at character introduction (regression). By ↵Travis Howell
restoring the kEngineBlockInput engine flag. svn-id: r48464
2010-04-02Fixed bug 2976767 on corrupted char glyphs.Robert Špalek
After unfinished translation of the game, several inaccessible characters have been left in the game files. Since the font does not contain all 256 characters, trying to draw them brings them random jump. I now properly skip these characters. svn-id: r48462
2010-04-01Dragon History: fixing properly bug 2976774Robert Špalek
The previous bugfix just hid the problem by removing an assert, but it might demonstrate itself in another way later. This is a proper bugfix. svn-id: r48460
2010-04-01Added an "fxq" debugger command to print the FX queue. I guess it might help inTorbjörn Andersson
debugging the "No free slot in FX queue!" bug I've heard of but never actually seen. (See for instance bug #2976008, "BS2: Game lockup in British Museum".) svn-id: r48458
2010-04-01Remove extra semicolonsOri Avtalion
svn-id: r48457
2010-03-31Basic correction for bug #2976774 "DRACI: Segfault Crash When Leaving ↵David Turner
Inventory". This patch corrects the valgrind fault, but may not be the ultimate fix. This should be reviewed before backport to v1.1.0 branch. svn-id: r48434
2010-03-30Let Parallaction return game-specific gameids. This completes the fix for ↵Nicola Mettifogo
bug 2969234 after LordHoto's patch. Users might need to readd their games. svn-id: r48422
2010-03-30Fix for Lure memory error indicated by Valgrind on Restart/Restore Screen ↵David Turner
(Temptress over Castle). This screen is displayed if you lose the fight with the Skorl in the Dragon Caves etc. This fix should be reviewed and then backported to v1.1.0 branch. svn-id: r48421