aboutsummaryrefslogtreecommitdiff
path: root/engines
AgeCommit message (Collapse)Author
2017-11-10XEEN: Fix rendering of town messagesPaul Gilbert
2017-11-10ENGINES: Improve output of unknown game variant detectionColin Snover
When a user tries to add a game expecting it to be a particular game for a particular engine, but a detector from another engine happens to match some files that exist in the game directory and reports on those files instead, this can cause a lot of confusion because the detector doesn't say what engine or game it thought it matched. This patch adds the name of the matching engine as well as any matching game IDs (if applicable) to the detector's logged output. It also provides more specific guidance about where to send the detection information (to the bug tracker), and properly wraps the first part of the report to 80 columns. Refs Trac#10272.
2017-11-10ENGINES: Continue to check file presence after a hash/size mismatchColin Snover
If an early file in the game's signature list has a hash/size mismatch, it is still necessary to continue to check the rest of the candidate files for existence, since the non-existence of candidate files is supposed to disqualify a game description as matching a game to an unknown variant. By quitting the file check early, the detector had been allowing descriptions to randomly match if there happened to be an early file in the detection list with the right name but wrong hash/size, even if some of the other signature files did not exist at all.
2017-11-10CGE: Remove garbage character from commentsColin Snover
2017-11-10BBVS: Remove all bit shifts of potentially negative integersColin Snover
Previous patches that removed shifts of constant negative values to eliminate UB were valid, but did not correct all places where this engine was potentially bit shifting negative values. There is no reason to not just use multiplication and division and let the compiler make the right choice for optimisation for an architecture, so that is what this patch does.
2017-11-10ALL: Fix misuse of comma operatorColin Snover
2017-11-10XEEN: Fix animation of wall torchesPaul Gilbert
2017-11-09Merge pull request #1049 from csnover/lure-unalignedPaul Gilbert
LURE: Stop taking address of unaligned pointer
2017-11-09XEEN: Cleanup of PowType enum namesPaul Gilbert
2017-11-09XEEN: Properly animate arrow shootingPaul Gilbert
2017-11-09XEEN: Create a PowType enum for ranged arrow/spell typesPaul Gilbert
2017-11-08XEEN: Changed multiAttack to rangedAttackPaul Gilbert
2017-11-07LURE: Stop taking address of unaligned pointerColin Snover
While usage of these pointers was technically safe because they were read through an alignment-aware API, taking the address of an unaligned pointer was generating warnings in Clang, and is not strictly necessary here. This change solves the warning and also protects this code from any future change that might cause it to start reading unsafely.
2017-11-07XEEN: Fix FX calls in multiAttackPaul Gilbert
2017-11-04TITANIC: Remove testing flag from German versionPaul Gilbert
2017-11-02MOHAWK: RIVEN: Remove the testing flagBastien Bouclet
2017-10-31SCUMM: Prevent false detection of Steam gamesBen Castricum
2017-10-29XEEN: Enable starting game from startup menuPaul Gilbert
2017-10-29SCI: Fix UB in SegManager memcpy/strcpy operationsColin Snover
Passing overlapping buffers to C standard library memcpy, strcpy, and strncpy is undefined behavior. In SSCI these operations would perform a forward copy, and most stdlib implementations do the same, but at least newer Linux glibc on x86 copies bytes in reverse, so just using the standard library on this platform results in broken output. Because SSCI used a blind forward copy instead of memmove for overlapping copy operations, this patch implements an explicit forward copy to ensure that overlapping copies continue to operate the same as in SSCI. This fixes the Island of Dr. Brain v1.1 flamingo puzzle (script 185, flamingos::init, localCall 4c3) on platforms that do not perform forward copy in memcpy/strcpy/strncpy. Thanks to @moralrecordings for research on this bug and an initial patch using memmove. Closes gh-1034.
2017-10-29TESTBED: Only build cloud tests if libcurl is available tooWillem Jan Palenstijn
This matches the module.mk checks for backends/cloud
2017-10-28Merge pull request #1046 from digitall/saga_ite_frenchThierry Crozat
SAGA: Add Code to Support French Fan Translation.
2017-10-28SAGA: Replace Remaining French Accented Characters with Escape Codes.D G Turner
2017-10-28SAGA: Add Define for French Language for clarity.D G Turner
2017-10-27TITANIC: Hopefully fix AmigaOS compilationPaul Gilbert
2017-10-27SAGA: Correct Tenses in French Fan Translation of ITE.D G Turner
These changes were suggested by bgK.
2017-10-26SAGA: Add Code to Support French Fan Translation.D G Turner
This code was supplied by Darknior (hugues.fabien@gmail.com).
2017-10-25Merge pull request #1035 from bgK/require-64bits-integersBastien Bouclet
BUILD: Require 64bits integers
2017-10-25MOHAWK: MYST: Add detection for a Russian versionBastien Bouclet
2017-10-21SCI: Allow lofsa string printing in disasm for all SCI versionsWillem Jan Palenstijn
2017-10-21SCI: Fix offsets in disasm for multi-param opcodesWillem Jan Palenstijn
This code was assuming that retval points to the start of the next instruction, which is only true if the current parameter is the last one. This fixes op_call printing.
2017-10-16TITANIC: Remove redundant room check in CEarSweetBowlPaul Gilbert
2017-10-16SCI32: Fix cursor color when quitting for phant1David Fioramonti
When quitting the game at the main menu and hitting no or quitting the game while playing the cursor color over the buttons will be tan the first time rather than red. This fix makes it so it will be red. This was done by removing a check in HotSpot::doit() which checks the global193 value. Removing this check fixes the problem. Fixes Trac#9977. Thanks snover and wjp for your help.
2017-10-15TITANIC: Add missing strings for Floor & Room # to titanic.datPaul Gilbert
2017-10-15TITANIC: Fix crash exiting game when music room music is activePaul Gilbert
2017-10-15TITANIC: Music room handler field renames & better anim sync to musicPaul Gilbert
2017-10-15SCI32: Tell OSystem to show/hide cursors as appropriateColin Snover
This is needed so that the system cursor can be appropriately hidden outside the game's draw area, to match the normal behaviour of ScummVM.
2017-10-15TITANIC: Fix use after free and remove IFDEF code from mouse cursorsPaul Gilbert
2017-10-15TITANIC: Simplify cursors to build up as RGBA during loadingPaul Gilbert
2017-10-14TITANIC: Remove accidentally committed cutscene slowdownPaul Gilbert
2017-10-14TITANIC: Stop final piano note of music room music getting cut offPaul Gilbert
2017-10-14TITANIC: Properly flag audio buffer as finished when song is donePaul Gilbert
2017-10-13TITANIC: Fix rotating on Top of Well balconyPaul Gilbert
2017-10-13TITANIC: Show busy cursor when SuccUBus sending or receivingPaul Gilbert
2017-10-13TITANIC: Workaround for wrong ambient music on loadPaul Gilbert
2017-10-13TITANIC: Renamed GlobalSound methods to AmbientSoundPaul Gilbert
2017-10-13TITANIC: Cleanup of auto music player classes and messagesPaul Gilbert
2017-10-12TITANIC: Play Pellerator sound only when moving to a new destinationPaul Gilbert
2017-10-12TITANIC: DE: Fix showing accented characters in Chat tabPaul Gilbert
2017-10-12TITANIC: DE: Fix saying 'ja' to Deskbot during checkinPaul Gilbert
2017-10-10TITANIC: Fix buffer overflow in parser searchAndReplacePaul Gilbert