Age | Commit message (Collapse) | Author | |
---|---|---|---|
2018-01-27 | GUI: Implement dirty-checking for widget redraws | Bastien Bouclet | |
2017-12-03 | BASE: Remove bad casts between incompatible Plugin types | Colin Snover | |
Previously, a C-style cast was used to convert a Common::Array<Plugin *>, populated with pointers to StaticPlugin and DynamicPlugin instances, to a Common::Array<PluginSubclass<T> *>, but PluginSubclass<T> is a *sibling* class to StaticPlugin/DynamicPlugin, so this cast was invalid and the results undefined. The methods for retrieving subclasses of plugins can't be easily changed to just generate an array of temporary wrapper objects that expose an identical API which dereferences to the preferred PluginObject subclass because pointers to these objects are retained by other parts of ScummVM, so the wrappers would needed to be persisted or they would need to just re-expose the underlying Plugin object again. This indicated that a way to solve this problem is to have the callers receive Plugin objects and get the PluginObject from the Plugin by explicitly stating their desired type, in a similar manner to std::get(std::variant), so that the pattern used by this patch to solve the problem. Closes gh-1051. | |||
2016-04-14 | JANITORIAL: Reduce GUI header dependencies | Ori Avtalion | |
2015-10-11 | I18N: Mark additional string for translation | Thierry Crozat | |
2014-02-18 | GUI: Make GPL headers consistent in themselves. | Johannes Schickel | |
2013-07-15 | GUI: Allow the event recorder dialog to be closed. | Johannes Schickel | |
This is a regression from 6e4217e1ba1df9fd2ee4cd0d61151ed7dfc53021. setResult does not automatically close the dialog. However, Dialog::handleCommand will close the dialog when kCloseCmd is received. | |||
2013-07-14 | RECORDER: Fix indenting | Sven Hesse | |
2013-07-14 | JANITORIAL: Remove trailing whitespace | Sven Hesse | |
2013-07-14 | RECORDER: Fix CID 1046887. Missing break in switch | Eugene Sandulenko | |
2013-07-14 | RECORDER: Fix CID 1046882. Uninitalized variables | Eugene Sandulenko | |
2013-05-17 | RECORDER: Implement Events Recorder | Eugene Sandulenko | |