aboutsummaryrefslogtreecommitdiff
path: root/gui/recorderdialog.cpp
AgeCommit message (Collapse)Author
2018-01-27GUI: Implement dirty-checking for widget redrawsBastien Bouclet
2017-12-03BASE: Remove bad casts between incompatible Plugin typesColin Snover
Previously, a C-style cast was used to convert a Common::Array<Plugin *>, populated with pointers to StaticPlugin and DynamicPlugin instances, to a Common::Array<PluginSubclass<T> *>, but PluginSubclass<T> is a *sibling* class to StaticPlugin/DynamicPlugin, so this cast was invalid and the results undefined. The methods for retrieving subclasses of plugins can't be easily changed to just generate an array of temporary wrapper objects that expose an identical API which dereferences to the preferred PluginObject subclass because pointers to these objects are retained by other parts of ScummVM, so the wrappers would needed to be persisted or they would need to just re-expose the underlying Plugin object again. This indicated that a way to solve this problem is to have the callers receive Plugin objects and get the PluginObject from the Plugin by explicitly stating their desired type, in a similar manner to std::get(std::variant), so that the pattern used by this patch to solve the problem. Closes gh-1051.
2016-04-14JANITORIAL: Reduce GUI header dependenciesOri Avtalion
2015-10-11I18N: Mark additional string for translationThierry Crozat
2014-02-18GUI: Make GPL headers consistent in themselves.Johannes Schickel
2013-07-15GUI: Allow the event recorder dialog to be closed.Johannes Schickel
This is a regression from 6e4217e1ba1df9fd2ee4cd0d61151ed7dfc53021. setResult does not automatically close the dialog. However, Dialog::handleCommand will close the dialog when kCloseCmd is received.
2013-07-14RECORDER: Fix indentingSven Hesse
2013-07-14JANITORIAL: Remove trailing whitespaceSven Hesse
2013-07-14RECORDER: Fix CID 1046887. Missing break in switchEugene Sandulenko
2013-07-14RECORDER: Fix CID 1046882. Uninitalized variablesEugene Sandulenko
2013-05-17RECORDER: Implement Events RecorderEugene Sandulenko