Age | Commit message (Collapse) | Author |
|
|
|
The big reveal
|
|
|
|
|
|
|
|
Calling reflowLayout() not only updates the layout (as setupCloudTab()
was already doing), but also recalculates scrollbar. The issue was that
old layout didn't need a scrollbar, but updated layout did. But,
ScrollContainer was not notified, and thus scrollbar didn't appear
(until user tried to reselect the Storage via popup).
|
|
This comment for fall through to prevent the compiler warning about
this has to be at the point of fallthrough i.e. outside the grouping
brackets to be effective.
|
|
These were incorrectly positioned (typos in code, missing value in one
expression).
|
|
|
|
Well, it ain't a fix, because it's not exactly correct for any of the
themes. Yet it's the best for all of them. If I put what seems to be
correct, "modern" theme gets ruined, because it has this mystical 2px
offset in tabs/scrollcontainers.
|
|
- removed +1px in ListWidget, added in lordhoto's 2007 commit 68eb28a
(aka r29971 in svn) `Fix for bug #1670082 "GUI: Modern theme gfx glitch
in launcher".`, because it made clip this last line of scrollbar in all
themes, which doesn't look good. In 2007 theme was written in .ini,
which is not the case now. I don't see any glitches after removing this
"fix";
- fixed how scrollbar top and bottom scroll buttons are drawn in
ThemeEngine::drawScrollbar: there were these weird magic numbers, but in
reality extra space that buttons should occupy is hardcoded in
scrollbar.cpp (ScrollBarWidget) and is just +1px.
|
|
|
|
|
|
For more security, newly connected Storage only gets username/used space
information and is disabled until user manually presses the button.
|
|
- added missing 'd' in "%d" in SavesSyncRequest;
- removed trailing ',' in enum in gui/options.h;
- fixed #endif to have // before USE_LIBCURL in gui/options.h.
|
|
|
|
|
|
GlobalOptionsDialog is now also a CommandSender, so it could send
command "scroll to the top" when storage is disconnected in Cloud tab
(layout updates, that's why scrolling is needed).
|
|
Now input box does not remember old code you've put in it if you changed
selected storage or disconnected one.
|
|
Elements were displayed until scrollbar was used, now they are hidden
right after storage is connected.
|
|
All local webserver-related settings are now shown in a separate, "Wi-Fi
Sharing" tab (shown if built with USE_SDL_NET). Cloud tab is only shown
if actual cloud storages are built (USE_LIBCURL).
|
|
- StorageWizardDialog is removed, along with bmps it was using;
- EditTextWidget now accepts custom font in constructor;
- ScrollContainer scrollbar now jumps to top when content height changes
so it's "overscrolled";
- IndexPageHandler now does not awaits for `code` GET-parameter, as
local webserver is no longer used to connect Storages;
- CloudManager and all corresponding Storages are updated to support
disconnecting and to notify about successful connection.
|
|
|
|
|
|
This function was used in cloud-related DownloadDialog before,
and now it is also used in Options > Cloud tab.
|
|
|
|
correspondingly
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This reverts commit 62cf04f5022953542540ab0d1a3dca4aae9adf18.
|
|
He was last active in 2009 and has long moved on to work on other things.
|
|
* The list of candidates now includes unknown variants. When an unknown
variant is selected, the unknown game dialog is shown.
* On the unknown game dialog, users are given the choice to add the game
when that is possible, or to cancel.
The goal of those changes is to make the unknown game dialog less
confusing for users, especially when both known and unknown games
variants are found.
|
|
The GUI system was originally written completely by me, as is easily
verifiable by inspecting the commit logs of the gui subdirectory, or e.g.
specific files like gui/widget.cpp.
|
|
|
|
|
|
This is a signed vs. unsigned comparison warning from GCC.
|
|
|
|
|
|
The redirect rule on the web site expected only two query items, one
with the engine name and another one with the description. However it
was a bit lax in its regex and we could pass additional query items
as part of either the engine name or description. The unknown game
dialog was abusing it to pass a summary.
The rewrite rule for the URL on the web site has now been fixed to
avoid such abuse. And instead it also adds a summary. So the
unknown name dialog should no longer provide one.
|
|
|