From 304ac2a7c4a3164504ad292de057f5b821fcbc58 Mon Sep 17 00:00:00 2001 From: Torbjörn Andersson Date: Wed, 2 Jan 2013 21:25:51 +0100 Subject: TINSEL: Fix another Clang analyzer warning Whether or not SaveFailure() can delete the save file, we want to invalidate the save name because it probably only lives on the stack so the pointer will become invalid once DoSave() has ended. --- engines/tinsel/saveload.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/engines/tinsel/saveload.cpp b/engines/tinsel/saveload.cpp index 2ef92d853f..acff196916 100644 --- a/engines/tinsel/saveload.cpp +++ b/engines/tinsel/saveload.cpp @@ -540,8 +540,8 @@ static void SaveFailure(Common::OutSaveFile *f) { if (f) { delete f; _vm->getSaveFileMan()->removeSavefile(g_SaveSceneName); - g_SaveSceneName = NULL; // Invalidate save name } + g_SaveSceneName = NULL; // Invalidate save name GUI::MessageDialog dialog(_("Failed to save game state to file.")); dialog.runModal(); } -- cgit v1.2.3