From 53d0fe22d902efa196ae1da03245d56f543c0ae2 Mon Sep 17 00:00:00 2001
From: Thierry Crozat
Date: Mon, 30 Jul 2018 19:18:52 +0100
Subject: COMMON: Fix HashMap never reusing erased items storage

When erasing and inserting many items this caused the hashmap capacity
to grow more than it should which resulted in performances issues (and
possibly memory issues as well). The issue was reported on IRC today
with the wintermute engine.
---
 common/hashmap.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/hashmap.h b/common/hashmap.h
index 1f93b68455..7913d8fc8b 100644
--- a/common/hashmap.h
+++ b/common/hashmap.h
@@ -507,7 +507,7 @@ typename HashMap<Key, Val, HashFunc, EqualFunc>::size_type HashMap<Key, Val, Has
 #ifdef DEBUG_HASH_COLLISIONS
 			_dummyHits++;
 #endif
-			if (first_free != _mask + 1)
+			if (first_free == NONE_FOUND)
 				first_free = ctr;
 		} else if (_equal(_storage[ctr]->_key, key)) {
 			found = true;
@@ -528,7 +528,7 @@ typename HashMap<Key, Val, HashFunc, EqualFunc>::size_type HashMap<Key, Val, Has
 		(const void *)this, _mask + 1, _size);
 #endif
 
-	if (!found && first_free != _mask + 1)
+	if (!found && first_free != NONE_FOUND)
 		ctr = first_free;
 
 	if (!found) {
-- 
cgit v1.2.3