From 772affc7dbb75faad85b69c00b381d12340f809d Mon Sep 17 00:00:00 2001
From: Max Horn
Date: Sat, 21 Oct 2006 11:14:41 +0000
Subject: Yuck, mark abuse of OSystem::setSoundCallback

svn-id: r24404
---
 sound/mods/protracker.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sound/mods/protracker.cpp b/sound/mods/protracker.cpp
index 8948ae4c20..591c0276ac 100644
--- a/sound/mods/protracker.cpp
+++ b/sound/mods/protracker.cpp
@@ -35,6 +35,13 @@ void ProtrackerPlayer::init(OSystem *system) {
 
 	_buf = new SoundBuffer();
 
+// FIXME BROKEN: You must NOT use OSystem::setSoundCallback(),
+// ever! The only piece of code allowed to use it is the mixer.
+// And soon the call might be removed completely, too.
+// The proper way to do this is to create a AudioStream
+// subclass and hook that with the mixer. See also the
+// code used by other softsynths (sound/softsynth/emumidi.h).
+
 	_system->setSoundCallback(&audioCallback, this);
 }
 
-- 
cgit v1.2.3