From ad3ab61241d5878c9b66f78f3927adb97f5a84e8 Mon Sep 17 00:00:00 2001
From: Bastien Bouclet
Date: Fri, 16 Oct 2015 20:26:34 +0200
Subject: COMMON: Remove the EventRecorder dependency from OSystem

EventRecorder is in the gui lib which is not linked in the cxxtest suite.
---
 backends/platform/sdl/sdl.cpp | 8 ++++++++
 backends/platform/sdl/sdl.h   | 1 +
 common/system.cpp             | 7 -------
 common/system.h               | 2 +-
 4 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/backends/platform/sdl/sdl.cpp b/backends/platform/sdl/sdl.cpp
index c55753194b..dca6891fef 100644
--- a/backends/platform/sdl/sdl.cpp
+++ b/backends/platform/sdl/sdl.cpp
@@ -492,6 +492,14 @@ AudioCDManager *OSystem_SDL::createAudioCDManager() {
 #endif
 }
 
+Common::SaveFileManager *OSystem_SDL::getSavefileManager() {
+#ifdef ENABLE_EVENTRECORDER
+    return g_eventRec.getSaveManager(_savefileManager);
+#else
+    return _savefileManager;
+#endif
+}
+
 #ifdef USE_OPENGL
 
 const OSystem::GraphicsMode *OSystem_SDL::getSupportedGraphicsModes() const {
diff --git a/backends/platform/sdl/sdl.h b/backends/platform/sdl/sdl.h
index c93c8308a7..1fe670c5c3 100644
--- a/backends/platform/sdl/sdl.h
+++ b/backends/platform/sdl/sdl.h
@@ -76,6 +76,7 @@ public:
 	virtual void getTimeAndDate(TimeDate &td) const;
 	virtual Audio::Mixer *getMixer();
 	virtual Common::TimerManager *getTimerManager();
+	virtual Common::SaveFileManager *getSavefileManager();
 
 protected:
 	bool _inited;
diff --git a/common/system.cpp b/common/system.cpp
index 53f28cafa1..131a7d2580 100644
--- a/common/system.cpp
+++ b/common/system.cpp
@@ -30,9 +30,6 @@
 #include "common/taskbar.h"
 #include "common/updates.h"
 #include "common/textconsole.h"
-#ifdef ENABLE_EVENTRECORDER
-#include "gui/EventRecorder.h"
-#endif
 
 #include "backends/audiocd/default/default-audiocd.h"
 #include "backends/fs/fs-factory.h"
@@ -161,9 +158,5 @@ Common::TimerManager *OSystem::getTimerManager() {
 }
 
 Common::SaveFileManager *OSystem::getSavefileManager() {
-#ifdef ENABLE_EVENTRECORDER
-	return g_eventRec.getSaveManager(_savefileManager);
-#else
 	return _savefileManager;
-#endif
 }
diff --git a/common/system.h b/common/system.h
index 8896554f76..6d185d3075 100644
--- a/common/system.h
+++ b/common/system.h
@@ -1090,7 +1090,7 @@ public:
 	 * and other modifiable persistent game data. For more information,
 	 * refer to the SaveFileManager documentation.
 	 */
-	Common::SaveFileManager *getSavefileManager();
+	virtual Common::SaveFileManager *getSavefileManager();
 
 #if defined(USE_TASKBAR)
 	/**
-- 
cgit v1.2.3


From 8d34d5190db8a7af9a63c802e4f14a3b8a4ee7d1 Mon Sep 17 00:00:00 2001
From: Bastien Bouclet
Date: Thu, 28 Jul 2016 18:23:50 +0200
Subject: Revert "BUILD: Fix test compilation with event recorder enabled"

This reverts commit 1f8667c5d949070035390531e4f10c0f945d7352.
---
 common/recorderfile.cpp | 4 ----
 common/scummsys.h       | 4 ----
 test/module.mk          | 1 -
 3 files changed, 9 deletions(-)

diff --git a/common/recorderfile.cpp b/common/recorderfile.cpp
index 04802aa0c8..71f8272b44 100644
--- a/common/recorderfile.cpp
+++ b/common/recorderfile.cpp
@@ -30,8 +30,6 @@
 #include "graphics/surface.h"
 #include "graphics/scaler.h"
 
-#ifdef ENABLE_EVENTRECORDER
-
 #define RECORD_VERSION 1
 
 namespace Common {
@@ -716,5 +714,3 @@ void PlaybackFile::checkRecordedMD5() {
 
 
 }
-
-#endif // ENABLE_EVENTRECORDER
diff --git a/common/scummsys.h b/common/scummsys.h
index 3513ee2d7d..5e1069fb46 100644
--- a/common/scummsys.h
+++ b/common/scummsys.h
@@ -215,10 +215,6 @@
 #include "config.h"
 #endif
 
-// Now we need to adjust some settings when running tests
-#ifdef COMPILING_TESTS
-#undef ENABLE_EVENTRECORDER
-#endif
 
 // In the following we configure various targets, in particular those
 // which can't use our "configure" tool and hence don't use config.h.
diff --git a/test/module.mk b/test/module.mk
index e591854ace..11ee6bd200 100644
--- a/test/module.mk
+++ b/test/module.mk
@@ -26,7 +26,6 @@ endif
 #TEST_LDFLAGS += -L/usr/X11R6/lib -lX11
 
 
-test: CXXFLAGS +=  -DCOMPILING_TESTS=1
 test: test/runner
 	./test/runner
 test/runner: test/runner.cpp $(TEST_LIBS)
-- 
cgit v1.2.3


From f980ef5524897eac047f0d794af3971c7c71a6a3 Mon Sep 17 00:00:00 2001
From: Bastien Bouclet
Date: Thu, 28 Jul 2016 18:25:05 +0200
Subject: BUILD: Don't disable the event recorder for TravisCI

Tests now build fine with the event recorder enabled
---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index 9965f168b8..0c88ec8f24 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -33,7 +33,7 @@ os:
   - linux
 
 script:
-  - ./configure --enable-all-engines --disable-eventrecorder
+  - ./configure --enable-all-engines
   - make -j 2
   - make test
   - make devtools
-- 
cgit v1.2.3