From b779f20502308c8db5c168c789f8867a13c8020b Mon Sep 17 00:00:00 2001
From: D G Turner
Date: Tue, 28 Feb 2017 20:42:17 +0000
Subject: CLOUD: Fix GCC Unused Variable Warning.

This variable is not used as the constructors for the storage type
classes store the resulting objects into the Cloud Manager using
replaceStorage(this) instead.
---
 backends/cloud/cloudmanager.cpp | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

(limited to 'backends/cloud')

diff --git a/backends/cloud/cloudmanager.cpp b/backends/cloud/cloudmanager.cpp
index 4fb38ad779..5519e4baab 100644
--- a/backends/cloud/cloudmanager.cpp
+++ b/backends/cloud/cloudmanager.cpp
@@ -253,27 +253,24 @@ void CloudManager::setStorageLastSync(uint32 index, Common::String date) {
 void CloudManager::connectStorage(uint32 index, Common::String code) {
 	freeStorages();
 
-	Storage *storage = nullptr;
 	switch (index) {
 	case kStorageDropboxId:
-		storage = new Dropbox::DropboxStorage(code);
+		new Dropbox::DropboxStorage(code);
 		break;
 	case kStorageOneDriveId:
-		storage = new OneDrive::OneDriveStorage(code);
+		new OneDrive::OneDriveStorage(code);
 		break;
 	case kStorageGoogleDriveId:
-		storage = new GoogleDrive::GoogleDriveStorage(code);
+		new GoogleDrive::GoogleDriveStorage(code);
 		break;
 	case kStorageBoxId:
-		storage = new Box::BoxStorage(code);
+		new Box::BoxStorage(code);
 		break;
 	}
 	// in these constructors Storages request token using the passed code
 	// when the token is received, they call replaceStorage()
 	// or removeStorage(), if some error occurred
 	// thus, no memory leak happens
-
-	// FIXME: storage is set, but never used. Should it be returned from this function for class variable _storages?
 }
 
 Networking::Request *CloudManager::listDirectory(Common::String path, Storage::ListDirectoryCallback callback, Networking::ErrorCallback errorCallback, bool recursive) {
-- 
cgit v1.2.3