From d1fa1154fe5758fe48928062ff9b43d1bcfc7770 Mon Sep 17 00:00:00 2001 From: Cameron Cawley Date: Sat, 9 Nov 2019 14:52:05 +0000 Subject: BACKENDS: Fix using fillScreen in non-paletted screen modes --- backends/graphics/opengl/opengl-graphics.cpp | 5 ----- backends/graphics/surfacesdl/surfacesdl-graphics.cpp | 4 ++-- 2 files changed, 2 insertions(+), 7 deletions(-) (limited to 'backends/graphics') diff --git a/backends/graphics/opengl/opengl-graphics.cpp b/backends/graphics/opengl/opengl-graphics.cpp index 9d11925613..f40b84c2bf 100644 --- a/backends/graphics/opengl/opengl-graphics.cpp +++ b/backends/graphics/opengl/opengl-graphics.cpp @@ -452,11 +452,6 @@ void OpenGLGraphicsManager::copyRectToScreen(const void *buf, int pitch, int x, } void OpenGLGraphicsManager::fillScreen(uint32 col) { - // FIXME: This does not conform to the OSystem specs because fillScreen - // is always taking CLUT8 color values and use color indexed mode. This is, - // however, plain odd and probably was a forgotten when we introduced - // RGB support. Thus, we simply do the "sane" thing here and hope OSystem - // gets fixed one day. _gameScreen->fill(col); } diff --git a/backends/graphics/surfacesdl/surfacesdl-graphics.cpp b/backends/graphics/surfacesdl/surfacesdl-graphics.cpp index 3b2e3eaf6f..7cddd4443f 100644 --- a/backends/graphics/surfacesdl/surfacesdl-graphics.cpp +++ b/backends/graphics/surfacesdl/surfacesdl-graphics.cpp @@ -1610,8 +1610,8 @@ void SurfaceSdlGraphicsManager::unlockScreen() { void SurfaceSdlGraphicsManager::fillScreen(uint32 col) { Graphics::Surface *screen = lockScreen(); - if (screen && screen->getPixels()) - memset(screen->getPixels(), col, screen->h * screen->pitch); + if (screen) + screen->fillRect(Common::Rect(screen->w, screen->h), col); unlockScreen(); } -- cgit v1.2.3