From 2232047695d8d26542c2f57d1c1daed7bfe4f5c5 Mon Sep 17 00:00:00 2001 From: Max Horn Date: Thu, 8 Feb 2007 22:54:09 +0000 Subject: The restriction on 'small' mouse cursors has been lifted quite some time ago; PalmOS and WinCE port should be extended accordingly (in particular, the PalmOS port would silently overwrite its memory when big cursors are used) svn-id: r25431 --- backends/platform/PalmOS/Src/os5_mouse.cpp | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'backends/platform/PalmOS/Src') diff --git a/backends/platform/PalmOS/Src/os5_mouse.cpp b/backends/platform/PalmOS/Src/os5_mouse.cpp index 375dc125ce..20e725694c 100644 --- a/backends/platform/PalmOS/Src/os5_mouse.cpp +++ b/backends/platform/PalmOS/Src/os5_mouse.cpp @@ -41,6 +41,15 @@ void OSystem_PalmOS5::setMouseCursor(const byte *buf, uint w, uint h, int hotspo if (w == 0 || h == 0) return; +FIXME: The restriction on MAX_MOUSE_H / MAX_MOUSE_W is obsolete; +in particular, BS2 might use bigger cursors these days. +See also bug #1609058. 1607180 +Hence this code now might overwrite memory unchecked; at the +very least an assert should be inserted to cause a controlled +crash, but of course it would be better to remove the restriction +on "small" cursors. + + _mouseCurState.w = w; _mouseCurState.h = h; -- cgit v1.2.3