From 4cc9d17c345883d4a764dd182d5a76167040c888 Mon Sep 17 00:00:00 2001 From: Max Horn Date: Tue, 11 Sep 2007 09:20:39 +0000 Subject: Adding various FIXME comments to bogus (non-self-explanatory) existing FIXME comments; and some other related cleanup svn-id: r28890 --- backends/platform/gp2x/gp2x-common.h | 2 +- backends/platform/gp32/gp32std_file.cpp | 2 ++ backends/platform/sdl/sdl.h | 6 +++--- backends/platform/wince/CELauncherDialog.cpp | 2 ++ backends/platform/wince/wince-sdl.cpp | 4 ++++ 5 files changed, 12 insertions(+), 4 deletions(-) (limited to 'backends/platform') diff --git a/backends/platform/gp2x/gp2x-common.h b/backends/platform/gp2x/gp2x-common.h index a48239222b..1812fdd8d9 100644 --- a/backends/platform/gp2x/gp2x-common.h +++ b/backends/platform/gp2x/gp2x-common.h @@ -165,7 +165,7 @@ public: void hideOverlay(); void clearOverlay(); void grabOverlay(OverlayColor *buf, int pitch); - void copyRectToOverlay(const OverlayColor *buf, int pitch, int x, int y, int w, int h); // WinCE FIXME + void copyRectToOverlay(const OverlayColor *buf, int pitch, int x, int y, int w, int h); int16 getHeight(); int16 getWidth(); int16 getOverlayHeight() { return _overlayHeight; } diff --git a/backends/platform/gp32/gp32std_file.cpp b/backends/platform/gp32/gp32std_file.cpp index 9269d69617..fcd9acf4da 100644 --- a/backends/platform/gp32/gp32std_file.cpp +++ b/backends/platform/gp32/gp32std_file.cpp @@ -224,6 +224,8 @@ size_t gp_fread(void *ptr, size_t size, size_t n, GPFILE *stream) { stream->filePos += len; #endif + // FIXME: Fingolfin asks: why is there a FIXME here? Please either clarify what + // needs fixing, or remove it! return 1; //readcount / size; //FIXME } diff --git a/backends/platform/sdl/sdl.h b/backends/platform/sdl/sdl.h index 38658ae76c..35e6dde1cd 100644 --- a/backends/platform/sdl/sdl.h +++ b/backends/platform/sdl/sdl.h @@ -161,11 +161,11 @@ public: void deleteMutex(MutexRef mutex); // Overlay - virtual void showOverlay(); // WinCE FIXME - virtual void hideOverlay(); // WinCE FIXME + virtual void showOverlay(); + virtual void hideOverlay(); virtual void clearOverlay(); virtual void grabOverlay(OverlayColor *buf, int pitch); - virtual void copyRectToOverlay(const OverlayColor *buf, int pitch, int x, int y, int w, int h); // WinCE FIXME + virtual void copyRectToOverlay(const OverlayColor *buf, int pitch, int x, int y, int w, int h); virtual int16 getHeight(); virtual int16 getWidth(); virtual int16 getOverlayHeight() { return _overlayHeight; } diff --git a/backends/platform/wince/CELauncherDialog.cpp b/backends/platform/wince/CELauncherDialog.cpp index 994bba6437..aef85ebf6c 100644 --- a/backends/platform/wince/CELauncherDialog.cpp +++ b/backends/platform/wince/CELauncherDialog.cpp @@ -47,6 +47,8 @@ public: : Dialog(10, 60, 300, 77) { char tempo[100]; + // FIXME: Fingolfin asks: why is there a FIXME here? Please either clarify what + // needs fixing, or remove it! addButton(this,(_w - kButtonWidth) / 2, 45, "OK", kCloseCmd, '\r'); // Close dialog - FIXME Common::String videoDriver("Using SDL driver "); diff --git a/backends/platform/wince/wince-sdl.cpp b/backends/platform/wince/wince-sdl.cpp index 2d6e9a4302..3487b1a649 100644 --- a/backends/platform/wince/wince-sdl.cpp +++ b/backends/platform/wince/wince-sdl.cpp @@ -1099,6 +1099,8 @@ bool OSystem_WINCE3::setGraphicsMode(int mode) { update_scalers(); + // FIXME: Fingolfin asks: why is there a FIXME here? Please either clarify what + // needs fixing, or remove it! // FIXME if (isOzone() && (getScreenWidth() >= 640 || getScreenHeight() >= 640) && mode) _scaleFactorXm = -1; @@ -1992,6 +1994,8 @@ void OSystem_WINCE3::hideOverlay() { } void OSystem_WINCE3::drawMouse() { + // FIXME: Fingolfin asks: why is there a FIXME here? Please either clarify what + // needs fixing, or remove it! // FIXME if (!(_toolbarHandler.visible() && _mouseCurState.y >= _toolbarHandler.getOffset() && !_usesEmulatedMouse) && !_forceHideMouse) internDrawMouse(); -- cgit v1.2.3