From 78f1ea769060cd631c210fc01020bb921afe3607 Mon Sep 17 00:00:00 2001
From: Eugene Sandulenko
Date: Fri, 5 Aug 2011 10:15:20 +0100
Subject: OSYSTEM: extended installTimerProc() with timer ID parameter

---
 backends/timer/default/default-timer.cpp | 2 +-
 backends/timer/default/default-timer.h   | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

(limited to 'backends/timer/default')

diff --git a/backends/timer/default/default-timer.cpp b/backends/timer/default/default-timer.cpp
index 8480fcc7ee..e17aaea444 100644
--- a/backends/timer/default/default-timer.cpp
+++ b/backends/timer/default/default-timer.cpp
@@ -109,7 +109,7 @@ void DefaultTimerManager::handler() {
 	}
 }
 
-bool DefaultTimerManager::installTimerProc(TimerProc callback, int32 interval, void *refCon) {
+bool DefaultTimerManager::installTimerProc(TimerProc callback, int32 interval, void *refCon, const Common::String &id) {
 	assert(interval > 0);
 	Common::StackLock lock(_mutex);
 
diff --git a/backends/timer/default/default-timer.h b/backends/timer/default/default-timer.h
index 66d2e3b091..33dd46cc57 100644
--- a/backends/timer/default/default-timer.h
+++ b/backends/timer/default/default-timer.h
@@ -22,6 +22,7 @@
 #ifndef BACKENDS_TIMER_DEFAULT_H
 #define BACKENDS_TIMER_DEFAULT_H
 
+#include "common/str.h"
 #include "common/timer.h"
 #include "common/mutex.h"
 
@@ -36,7 +37,7 @@ private:
 public:
 	DefaultTimerManager();
 	virtual ~DefaultTimerManager();
-	virtual bool installTimerProc(TimerProc proc, int32 interval, void *refCon);
+	virtual bool installTimerProc(TimerProc proc, int32 interval, void *refCon, const Common::String &id);
 	virtual void removeTimerProc(TimerProc proc);
 
 	/**
-- 
cgit v1.2.3


From 4c7958450f628937270f259cc480c1191ea2fb2f Mon Sep 17 00:00:00 2001
From: Eugene Sandulenko
Date: Fri, 5 Aug 2011 17:56:04 +0100
Subject: TIMER: Implemented checks for duplicated timers

---
 backends/timer/default/default-timer.cpp | 16 +++++++++++++++-
 backends/timer/default/default-timer.h   |  4 ++++
 2 files changed, 19 insertions(+), 1 deletion(-)

(limited to 'backends/timer/default')

diff --git a/backends/timer/default/default-timer.cpp b/backends/timer/default/default-timer.cpp
index e17aaea444..449dda2ece 100644
--- a/backends/timer/default/default-timer.cpp
+++ b/backends/timer/default/default-timer.cpp
@@ -24,10 +24,10 @@
 #include "common/util.h"
 #include "common/system.h"
 
-
 struct TimerSlot {
 	Common::TimerManager::TimerProc callback;
 	void *refCon;
+	Common::String id;
 	uint32 interval;	// in microseconds
 
 	uint32 nextFireTime;	// in milliseconds
@@ -113,9 +113,23 @@ bool DefaultTimerManager::installTimerProc(TimerProc callback, int32 interval, v
 	assert(interval > 0);
 	Common::StackLock lock(_mutex);
 
+	if (_callbacks.contains(id)) {
+		if (_callbacks[id] != callback) {
+			error("Different callbacks are referred by same name (%s)", id.c_str());
+	}
+	TimerSlotMap::const_iterator i;
+
+	for (i = _callbacks.begin(); i != _callbacks.end(); ++i) {
+		if (i->_value == callback) {
+			error("Same callback is referred by different names (%s vs %s)", i->_key.c_str(), id.c_str());
+		}
+	}
+	_callbacks[id] = callback;
+
 	TimerSlot *slot = new TimerSlot;
 	slot->callback = callback;
 	slot->refCon = refCon;
+	slot->id = id;
 	slot->interval = interval;
 	slot->nextFireTime = g_system->getMillis() + interval / 1000;
 	slot->nextFireTimeMicro = interval % 1000;
diff --git a/backends/timer/default/default-timer.h b/backends/timer/default/default-timer.h
index 33dd46cc57..e5a9dada79 100644
--- a/backends/timer/default/default-timer.h
+++ b/backends/timer/default/default-timer.h
@@ -23,6 +23,7 @@
 #define BACKENDS_TIMER_DEFAULT_H
 
 #include "common/str.h"
+#include "common/hash-str.h"
 #include "common/timer.h"
 #include "common/mutex.h"
 
@@ -30,9 +31,12 @@ struct TimerSlot;
 
 class DefaultTimerManager : public Common::TimerManager {
 private:
+	typedef Common::HashMap<Common::String, TimerProc, Common::IgnoreCase_Hash, Common::IgnoreCase_EqualTo> TimerSlotMap;
+
 	Common::Mutex _mutex;
 	void *_timerHandler;
 	TimerSlot *_head;
+	TimerSlotMap _callbacks;
 
 public:
 	DefaultTimerManager();
-- 
cgit v1.2.3


From 2fa17c44edf07f4f82147a6070950e7d8f7ee2f4 Mon Sep 17 00:00:00 2001
From: Eugene Sandulenko
Date: Fri, 5 Aug 2011 21:09:07 +0100
Subject: JANITORIAL: Remove SVN keywords

---
 backends/timer/default/default-timer.cpp | 1 +
 1 file changed, 1 insertion(+)

(limited to 'backends/timer/default')

diff --git a/backends/timer/default/default-timer.cpp b/backends/timer/default/default-timer.cpp
index 449dda2ece..efb3ec9ad9 100644
--- a/backends/timer/default/default-timer.cpp
+++ b/backends/timer/default/default-timer.cpp
@@ -116,6 +116,7 @@ bool DefaultTimerManager::installTimerProc(TimerProc callback, int32 interval, v
 	if (_callbacks.contains(id)) {
 		if (_callbacks[id] != callback) {
 			error("Different callbacks are referred by same name (%s)", id.c_str());
+		}
 	}
 	TimerSlotMap::const_iterator i;
 
-- 
cgit v1.2.3