From 34bf3f2de0e2722f8a6e951e8fb5be069ba7299f Mon Sep 17 00:00:00 2001 From: Bastien Bouclet Date: Fri, 15 Nov 2019 21:24:22 +0100 Subject: TTS: Fix use of virtual function in TTSMan destructor TextToSpeechManager::freeVoiceData was called while the virtual function table pointer was already reset by the parent class destructor. --- common/text-to-speech.cpp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) (limited to 'common/text-to-speech.cpp') diff --git a/common/text-to-speech.cpp b/common/text-to-speech.cpp index fa74e53c36..8e4742b3e9 100644 --- a/common/text-to-speech.cpp +++ b/common/text-to-speech.cpp @@ -88,15 +88,6 @@ TextToSpeechManager::TextToSpeechManager() { _ttsState->_next = nullptr; } -TextToSpeechManager::~TextToSpeechManager() { - TTSState *tmp = _ttsState; - while (tmp != nullptr) { - tmp = _ttsState->_next; - delete _ttsState; - _ttsState = tmp; - } -} - void TextToSpeechManager::pushState() { stop(); TTSState *newState = new TTSState; @@ -130,6 +121,15 @@ bool TextToSpeechManager::popState() { return false; } +void TextToSpeechManager::clearState() { + TTSState *tmp = _ttsState; + while (tmp != nullptr) { + tmp = _ttsState->_next; + delete _ttsState; + _ttsState = tmp; + } +} + TTSVoice TextToSpeechManager::getVoice() { if (!_ttsState->_availableVoices.empty()) return _ttsState->_availableVoices[_ttsState->_activeVoice]; -- cgit v1.2.3