From f96c8f6e39e39a92adfeeb07db78861ee7383226 Mon Sep 17 00:00:00 2001 From: David Turner Date: Fri, 31 Dec 2010 09:14:49 +0000 Subject: CINE: Fix CollisionPage Uninitialised Reads in Operation Stealth. The collisionPage is only initialised with values when loadCtFw() / loadCtOS() is called. However, currently during the display of the Delphine Software Logo in Operation Stealth, checkCollision() is called, but the collisionPage has not been loaded. To fix the invalid reads, have added code to set the page to zero after allocation. Shouldn't cause any issues to FW as this will load over the top anyway. Have also added debug output around this behaviour so that if this is not sufficient i.e. a collision page load is actually missing, then this will aid investigation. svn-id: r55071 --- engines/cine/cine.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'engines/cine/cine.h') diff --git a/engines/cine/cine.h b/engines/cine/cine.h index dd00d9b206..5f49a2907f 100644 --- a/engines/cine/cine.h +++ b/engines/cine/cine.h @@ -217,9 +217,10 @@ enum { }; enum { - kCineDebugScript = 1 << 0, - kCineDebugPart = 1 << 1, - kCineDebugSound = 1 << 2 + kCineDebugScript = 1 << 0, + kCineDebugPart = 1 << 1, + kCineDebugSound = 1 << 2, + kCineDebugCollision = 1 << 3 }; enum { -- cgit v1.2.3