From a2bdff02d78018b8aa2b763d7d1ae8ef050934cd Mon Sep 17 00:00:00 2001 From: Colin Snover Date: Sat, 7 Oct 2017 23:18:57 -0500 Subject: ENGINES: Improve output of unknown game variant detection When a user tries to add a game expecting it to be a particular game for a particular engine, but a detector from another engine happens to match some files that exist in the game directory and reports on those files instead, this can cause a lot of confusion because the detector doesn't say what engine or game it thought it matched. This patch adds the name of the matching engine as well as any matching game IDs (if applicable) to the detector's logged output. It also provides more specific guidance about where to send the detection information (to the bug tracker), and properly wraps the first part of the report to 80 columns. Refs Trac#10272. --- engines/gob/detection/detection.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'engines/gob/detection') diff --git a/engines/gob/detection/detection.cpp b/engines/gob/detection/detection.cpp index b0aa78f416..e204ced1e8 100644 --- a/engines/gob/detection/detection.cpp +++ b/engines/gob/detection/detection.cpp @@ -77,7 +77,10 @@ const ADGameDescription *GobMetaEngine::fallbackDetect(const FileMap &allFiles, return 0; } - reportUnknown(fslist.begin()->getParent(), filesProps); + ADGameIdList gameIds; + gameIds.push_back(game->desc.gameId); + + reportUnknown(fslist.begin()->getParent(), filesProps, gameIds); return (const ADGameDescription *)game; } -- cgit v1.2.3