From 53cd6616c958e4a50644254688aea222177f2ae2 Mon Sep 17 00:00:00 2001 From: Evgeny Grechnikov Date: Sun, 14 Oct 2018 20:05:54 +0300 Subject: LASTEXPRESS: refactor sound flags Merge SoundFlag and SoundStatus into a single enum; SoundEntry::setupStatus just casts one to another. Keep only definitions of bits in SoundFlag; drop compound flags like kFlagSteam = kSoundTypeAmbient | kSoundFlagLooped | kVolume7, use ORed simple flags in calls; change the signature of SoundManager::playSoundWithSubtitles to use uint32 instead of SoundFlag to avoid excess casting. Add meaningful names to flags; add some comments. Get rid of endian-unsafe SoundStatusUnion. Fixes an issue with big-endian hosts. No changes in behaviour on little-endian hosts. --- engines/lastexpress/entities/coudert.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'engines/lastexpress/entities/coudert.cpp') diff --git a/engines/lastexpress/entities/coudert.cpp b/engines/lastexpress/entities/coudert.cpp index 4a714e2852..af06d610e7 100644 --- a/engines/lastexpress/entities/coudert.cpp +++ b/engines/lastexpress/entities/coudert.cpp @@ -249,7 +249,7 @@ IMPLEMENT_FUNCTION_NOSETUP(7, Coudert, playSound16) break; case kActionDefault: - getSound()->playSound(kEntityCoudert, (char *)¶ms->seq1, kFlagDefault); + getSound()->playSound(kEntityCoudert, (char *)¶ms->seq1, kVolumeFull); break; case kActionCallback: -- cgit v1.2.3