From 29847ea42da3e597d3496972c80ce49bea76da20 Mon Sep 17 00:00:00 2001 From: Max Horn Date: Wed, 23 Mar 2011 15:23:26 +0100 Subject: AUDIO: Change several fake MidiDrivers to MidiDriver_BASE subclasses Many engines follow the advice in audio/midiparser.h and create a "pseudo-MidiDriver" subclass. But MidiParser really only needs a tiny subset of the MidiDriver capabilities, namely those found in MidiDriver_BASE. So we try to subclass from that whenever possible; this allows us to remove many stub methods, and enables further future simplifications. --- engines/m4/midi.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'engines/m4/midi.cpp') diff --git a/engines/m4/midi.cpp b/engines/m4/midi.cpp index 3a6475da89..36f7f29a2e 100644 --- a/engines/m4/midi.cpp +++ b/engines/m4/midi.cpp @@ -33,11 +33,12 @@ namespace M4 { MidiPlayer::MidiPlayer(MadsM4Engine *vm, MidiDriver *driver) : _vm(vm), _midiData(NULL), _driver(driver), _isPlaying(false), _passThrough(false), _isGM(false) { + assert(_driver); memset(_channel, 0, sizeof(_channel)); _masterVolume = 0; _parser = MidiParser::createParser_SMF(); _parser->setMidiDriver(this); - _parser->setTimerRate(getBaseTempo()); + _parser->setTimerRate(_driver->getBaseTempo()); open(); } @@ -83,10 +84,6 @@ int MidiPlayer::open() { return 0; } -bool MidiPlayer::isOpen() const { - return _driver && _driver->isOpen(); -} - void MidiPlayer::close() { stopMusic(); if (_driver) { -- cgit v1.2.3