From f24346aad7a773c127a6b557c984ee8140b705a5 Mon Sep 17 00:00:00 2001 From: Strangerke Date: Wed, 6 Aug 2014 19:06:19 +0200 Subject: MADS: Avoid potential buffer overflows --- engines/mads/nebular/menu_nebular.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'engines/mads/nebular/menu_nebular.cpp') diff --git a/engines/mads/nebular/menu_nebular.cpp b/engines/mads/nebular/menu_nebular.cpp index cb8f56bd05..4743ec4743 100644 --- a/engines/mads/nebular/menu_nebular.cpp +++ b/engines/mads/nebular/menu_nebular.cpp @@ -408,7 +408,7 @@ char TextView::_resourceName[100]; void TextView::execute(MADSEngine *vm, const Common::String &resName) { assert(resName.size() < 100); - strcpy(_resourceName, resName.c_str()); + strncpy(_resourceName, resName.c_str(), sizeof(_resourceName)); vm->_dialogs->_pendingDialog = DIALOG_TEXTVIEW; } @@ -460,7 +460,7 @@ void TextView::processLines() { processCommand(); // Copy rest of line (if any) to start of buffer - strcpy(_currentLine, cEnd + 1); + strncpy(_currentLine, cEnd + 1, sizeof(_currentLine)); cStart = strchr(_currentLine, '['); } @@ -631,7 +631,7 @@ char AnimationView::_resourceName[100]; void AnimationView::execute(MADSEngine *vm, const Common::String &resName) { assert(resName.size() < 100); - strcpy(_resourceName, resName.c_str()); + strncpy(_resourceName, resName.c_str(), sizeof(_resourceName)); vm->_dialogs->_pendingDialog = DIALOG_ANIMVIEW; } -- cgit v1.2.3