From 22882f54e19c1317d89e92e0578bcc94e2007e7f Mon Sep 17 00:00:00 2001 From: Bastien Bouclet Date: Sun, 7 Feb 2016 14:50:28 +0100 Subject: MOHAWK: Fix uninitialized memory accesses in the Myst stacks --- engines/mohawk/myst_stacks/credits.cpp | 1 + engines/mohawk/myst_stacks/mechanical.cpp | 3 +++ engines/mohawk/myst_stacks/selenitic.cpp | 4 ++++ engines/mohawk/myst_stacks/stoneship.cpp | 2 ++ 4 files changed, 10 insertions(+) (limited to 'engines/mohawk') diff --git a/engines/mohawk/myst_stacks/credits.cpp b/engines/mohawk/myst_stacks/credits.cpp index b9ff8b26aa..6548dd3171 100644 --- a/engines/mohawk/myst_stacks/credits.cpp +++ b/engines/mohawk/myst_stacks/credits.cpp @@ -37,6 +37,7 @@ namespace MystStacks { Credits::Credits(MohawkEngine_Myst *vm) : MystScriptParser(vm) { setupOpcodes(); + _curImage = 0; } Credits::~Credits() { diff --git a/engines/mohawk/myst_stacks/mechanical.cpp b/engines/mohawk/myst_stacks/mechanical.cpp index b1f23d37e4..4f8ce54923 100644 --- a/engines/mohawk/myst_stacks/mechanical.cpp +++ b/engines/mohawk/myst_stacks/mechanical.cpp @@ -40,6 +40,9 @@ Mechanical::Mechanical(MohawkEngine_Myst *vm) : setupOpcodes(); _elevatorGoingMiddle = false; + _elevatorPosition = 0; + + _crystalLit = 0; _mystStaircaseState = false; _fortressPosition = 0; diff --git a/engines/mohawk/myst_stacks/selenitic.cpp b/engines/mohawk/myst_stacks/selenitic.cpp index 034c6c8729..2617bd04aa 100644 --- a/engines/mohawk/myst_stacks/selenitic.cpp +++ b/engines/mohawk/myst_stacks/selenitic.cpp @@ -41,6 +41,10 @@ Selenitic::Selenitic(MohawkEngine_Myst *vm) : setupOpcodes(); _mazeRunnerPosition = 288; _mazeRunnerDirection = 8; + _mazeRunnerDoorOpened = false; + + _soundReceiverDirection = 0; + _soundReceiverStartTime = 0; } Selenitic::~Selenitic() { diff --git a/engines/mohawk/myst_stacks/stoneship.cpp b/engines/mohawk/myst_stacks/stoneship.cpp index 939e84075f..293c0f96f4 100644 --- a/engines/mohawk/myst_stacks/stoneship.cpp +++ b/engines/mohawk/myst_stacks/stoneship.cpp @@ -50,6 +50,8 @@ Stoneship::Stoneship(MohawkEngine_Myst *vm) : _chestDrawersOpen = 0; _chestAchenarBottomDrawerClosed = 1; + _brotherDoorOpen = 0; + // Drop key if (_state.trapdoorKeyState == 1) _state.trapdoorKeyState = 2; -- cgit v1.2.3