From 47a2f62c151c164b3e53392335b00af14a69f7a9 Mon Sep 17 00:00:00 2001
From: athrxx
Date: Tue, 16 Jul 2019 23:18:42 +0200
Subject: SCI: (FB01 sound driver) - several fixes

Fix SCI0 (LATE/EARLY) variants of the driver which were broken (didn't play at all). This might be of my own doing, since I introduced the initTrack() method into the driver class and the fb01 driver didn't have one so far.

SCI1 didn't seem to require much fixing. I modified some things according to my findings in the driver disasms. QFG2 and JONES seem to be fine. I am not too happy with KQ5. It has volume issues, but they might be present in the original, too.

I also added an isOpen() check and a mutex to avoid threading issues. When aborting SCI (either quitting ScummVM or returning ot the launcher) while using the fb01 driver I frequently (more often than not) got the assert from backends/midi/windows.cpp, line 95. This fixes that.

I've done plenty of checks and experiments with the sound bank initialization. But I found no bugs or possible improvements there. Hard to tell whether the sound is right. That device seems to have a mind of its own...
---
 engines/sci/POTFILES | 1 +
 1 file changed, 1 insertion(+)

(limited to 'engines/sci/POTFILES')

diff --git a/engines/sci/POTFILES b/engines/sci/POTFILES
index 015776c7a1..24576e871f 100644
--- a/engines/sci/POTFILES
+++ b/engines/sci/POTFILES
@@ -1,4 +1,5 @@
 engines/sci/detection.cpp
+engines/sci/sound/drivers/fb01.cpp
 engines/sci/engine/guest_additions.cpp
 engines/sci/engine/kfile.cpp
 engines/sci/engine/kgraphics.cpp
-- 
cgit v1.2.3