From c9ad2062db80fc9b6339bebdcd70f58269e38bf6 Mon Sep 17 00:00:00 2001 From: Colin Snover Date: Thu, 20 Oct 2016 11:23:43 -0500 Subject: SCI32: Fix wrong value passed to updateInfoFlagViewVisible updateInfoFlagViewVisible accepts a property index, not a selector ID. Fixes Trac#9583. --- engines/sci/engine/selector.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'engines/sci/engine/selector.cpp') diff --git a/engines/sci/engine/selector.cpp b/engines/sci/engine/selector.cpp index 3ae902215c..585b0ef2c2 100644 --- a/engines/sci/engine/selector.cpp +++ b/engines/sci/engine/selector.cpp @@ -233,12 +233,12 @@ void writeSelector(SegManager *segMan, reg_t object, Selector selectorId, reg_t if (lookupSelector(segMan, object, selectorId, &address, NULL) != kSelectorVariable) { const SciCallOrigin origin = g_sci->getEngineState()->getCurrentCallOrigin(); error("Selector '%s' of object could not be written to. Address %04x:%04x, %s", g_sci->getKernel()->getSelectorName(selectorId).c_str(), PRINT_REG(object), origin.toString().c_str()); - } else { - *address.getPointer(segMan) = value; + } + + *address.getPointer(segMan) = value; #ifdef ENABLE_SCI32 - updateInfoFlagViewVisible(segMan->getObject(object), selectorId); + updateInfoFlagViewVisible(segMan->getObject(object), address.varindex); #endif - } } void invokeSelector(EngineState *s, reg_t object, int selectorId, -- cgit v1.2.3