From 11a16fa30e8ea8dd5559d694cb9be660668d7842 Mon Sep 17 00:00:00 2001
From: Max Horn
Date: Tue, 1 Sep 2009 13:03:12 +0000
Subject: Coding best practice: Whenever possible, pass objects by reference
 instead of by value. Also make variables or data table which are only used
 locally "static".

svn-id: r43882
---
 engines/sci/detection.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'engines/sci')

diff --git a/engines/sci/detection.cpp b/engines/sci/detection.cpp
index 6f25d1cdc1..d0ae45a31f 100644
--- a/engines/sci/detection.cpp
+++ b/engines/sci/detection.cpp
@@ -163,7 +163,7 @@ public:
 	const ADGameDescription *fallbackDetect(const Common::FSList &fslist) const;
 };
 
-Common::String convertSierraGameId(Common::String sierraId, uint32 *gameFlags) {
+static Common::String convertSierraGameId(const Common::String &sierraId, uint32 *gameFlags) {
 	// TODO: SCI32 IDs
 
 	if (sierraId == "demo")
-- 
cgit v1.2.3