From 385421e95b59cf904e7e84edfe31d272a66da6b4 Mon Sep 17 00:00:00 2001
From: Max Horn
Date: Wed, 1 Jul 2009 20:51:47 +0000
Subject: Flag what looks like a bug in the CMS player code -- somebody should
 verify and fix this properly

svn-id: r42011
---
 engines/scumm/player_v2cms.cpp | 4 ++++
 1 file changed, 4 insertions(+)

(limited to 'engines/scumm/player_v2cms.cpp')

diff --git a/engines/scumm/player_v2cms.cpp b/engines/scumm/player_v2cms.cpp
index 97efb4dc63..d628293d7d 100644
--- a/engines/scumm/player_v2cms.cpp
+++ b/engines/scumm/player_v2cms.cpp
@@ -1428,6 +1428,10 @@ int Player_V2CMS::readBuffer(int16 *buffer, const int numSamples) {
 			}
 		
 			_tempoSum += _tempo;
+			// FIXME: _tempoSum is declared as char; on some systems char is unsigned.
+			// E.g. on OS X. Hence the following check is always false.
+			// Moral of the story: Use uint8, int8 or any of the other types provided by
+			// ScummVM if you want to ensure signedness and number of available bits.
 			if (_tempoSum < 0) {
 				// this have to be called in the same rate as in the original (I think)
 				processMidiData(1);
-- 
cgit v1.2.3