From 8a5705132d236f9bce49a420ddfff94157eabcb5 Mon Sep 17 00:00:00 2001 From: Max Horn Date: Mon, 16 Aug 2010 19:58:01 +0000 Subject: SCUMM: More finely differentiate opcode tables between v3, v4 and v5 This has been tested and verified as much as I can, but has a small risk of leading to (easily fixable) regressions. svn-id: r52130 --- engines/scumm/script_v3.cpp | 40 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) (limited to 'engines/scumm/script_v3.cpp') diff --git a/engines/scumm/script_v3.cpp b/engines/scumm/script_v3.cpp index 7d2efdb9a8..176eefdeef 100644 --- a/engines/scumm/script_v3.cpp +++ b/engines/scumm/script_v3.cpp @@ -24,6 +24,7 @@ */ #include "scumm/scumm_v3.h" +#include "scumm/actor.h" namespace Scumm { @@ -36,6 +37,11 @@ void ScummEngine_v3::setupOpcodes() { OPCODE(0x30, o3_setBoxFlags); OPCODE(0xb0, o3_setBoxFlags); } + + OPCODE(0x3b, o3_waitForActor); + OPCODE(0xbb, o3_waitForActor); + + OPCODE(0x4c, o3_waitForSentence); } void ScummEngine_v3::o3_setBoxFlags() { @@ -46,4 +52,38 @@ void ScummEngine_v3::o3_setBoxFlags() { setBoxFlags(a, b); } +void ScummEngine_v3::o3_waitForActor() { + // This opcode was a NOP in LOOM. Also, we cannot directly use + // o2_waitForActor because there the _scriptPointer is different (it + // assumes that getVar reads only a single byte, which is correct + // for v2 but not for v3). Of course we could copy the code here to + // o2_waitForActor and then merge the two, but right now I am + // keeping this as it is. + if (_game.id == GID_INDY3) { + const byte *oldaddr = _scriptPointer - 1; + Actor *a = derefActor(getVarOrDirectByte(PARAM_1), "o3_waitForActor"); + if (a->_moving) { + _scriptPointer = oldaddr; + o5_breakHere(); + } + } +} + +void ScummEngine_v3::o3_waitForSentence() { + // FIXME/TODO: Can we merge this with o2_waitForSentence? I think + // the code here is actually incorrect, and the code in + // o2_waitForSentence correct, but somebody should check the + // disassembly for Indy and Loom. + if (_sentenceNum) { + if (_sentence[_sentenceNum - 1].freezeCount && !isScriptInUse(VAR(VAR_SENTENCE_SCRIPT))) + return; + } else if (!isScriptInUse(VAR(VAR_SENTENCE_SCRIPT))) + return; + + _scriptPointer--; + o5_breakHere(); +} + + + } // End of namespace Scumm -- cgit v1.2.3