From 1dbf8d73d56052654522cf4076490090a41f336b Mon Sep 17 00:00:00 2001 From: Max Horn Date: Tue, 16 Nov 2010 09:53:55 +0000 Subject: TINSEL: Mark all (?) global vars with a FIXME comment Use of global vars is what prevents RTL from working in Tinsel (and probably in other engines). More specifically, the fact that many global vars are not explicitly inited when the engine is (re)launched. svn-id: r54262 --- engines/tinsel/play.cpp | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'engines/tinsel/play.cpp') diff --git a/engines/tinsel/play.cpp b/engines/tinsel/play.cpp index 103b8f42ad..145634b9dd 100644 --- a/engines/tinsel/play.cpp +++ b/engines/tinsel/play.cpp @@ -63,6 +63,8 @@ struct PPINIT { //----------------- LOCAL GLOBAL DATA -------------------- +// FIXME: Avoid non-const global vars + static SOUNDREELS soundReels[MAX_SOUNDREELS]; static int soundReelNumbers[MAX_SOUNDREELS]; @@ -432,6 +434,7 @@ static void t1PlayReel(CORO_PARAM, const PPINIT *ppi) { int tmpX, tmpY; CORO_END_CONTEXT(_ctx); + // FIXME: Avoid non-const global vars static int firstColZ = 0; // Z-position of column zero static int32 fColZfactor = 0; // Z-factor of column zero's actor @@ -818,6 +821,7 @@ static void t2PlayReel(CORO_PARAM, int x, int y, bool bRestore, int speed, SCNHA SoundReelWaitCheck(); } else { + // FIXME: Avoid non-const global vars static int baseZposn; // Z-position of column zero static uint32 baseZfact; // Z-factor of column zero's actor -- cgit v1.2.3