From 076bcbc5c6b4c0f34e919dccfb0d407e88138560 Mon Sep 17 00:00:00 2001
From: Torbjörn Andersson
Date: Fri, 23 Nov 2012 06:54:25 +0100
Subject: SCUMM: Added TODO comment about Mac MI1 music

Some notes in the main theme are very staccato, and this could
possibly explain why.
---
 engines/scumm/player_mac.cpp | 9 +++++++++
 1 file changed, 9 insertions(+)

(limited to 'engines')

diff --git a/engines/scumm/player_mac.cpp b/engines/scumm/player_mac.cpp
index fa0dd9d052..a91050e889 100644
--- a/engines/scumm/player_mac.cpp
+++ b/engines/scumm/player_mac.cpp
@@ -298,6 +298,15 @@ uint32 Player_Mac::durationToSamples(uint16 duration) {
 }
 
 int Player_Mac::noteToPitchModifier(byte note, Instrument *instrument) {
+	// TODO: Monkey Island 1 uses both note values 0 and 1 as rests.
+	// Perhaps 0 means an abrupt end of the current note, while 1 means it
+	// should drop off gradually? One of the voices in the main theme
+	// sounds a lot more staccato than what I hear in a Mac emulator. (But
+	// it's hard to tell since that emulator has problems with the music.)
+	// Also, some instruments (though not this particular one) have data
+	// after the loop end point, which could possible be used to fade out
+	// the instrument.
+
 	if (note > 1) {
 		const int pitchIdx = note + 60 - instrument->_baseFreq;
 		// I don't want to use floating-point arithmetics here, but I
-- 
cgit v1.2.3