From 7d6848dfa3ceebe2d618c8ba59a03cae631bacf1 Mon Sep 17 00:00:00 2001 From: Willem Jan Palenstijn Date: Thu, 1 Oct 2009 11:06:38 +0000 Subject: SCI: Add some fixmes noted by salty-horse. svn-id: r44513 --- engines/sci/console.cpp | 4 +++- engines/sci/sfx/softseq/amiga.cpp | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) (limited to 'engines') diff --git a/engines/sci/console.cpp b/engines/sci/console.cpp index ee300d251d..2e00127351 100644 --- a/engines/sci/console.cpp +++ b/engines/sci/console.cpp @@ -2719,7 +2719,9 @@ bool Console::cmdAddresses(int argc, const char **argv) { return true; } -int parse_reg_t(EngineState *s, const char *str, reg_t *dest) { // Returns 0 on success +// Returns 0 on success +int parse_reg_t(EngineState *s, const char *str, reg_t *dest) { + // FIXME: Stop this function from changing str. int rel_offsetting = 0; const char *offsetting = NULL; // Non-NULL: Parse end of string for relative offsets diff --git a/engines/sci/sfx/softseq/amiga.cpp b/engines/sci/sfx/softseq/amiga.cpp index 7eebadbf59..ff4057be3a 100644 --- a/engines/sci/sfx/softseq/amiga.cpp +++ b/engines/sci/sfx/softseq/amiga.cpp @@ -565,6 +565,7 @@ static void ami_event(sfx_softseq_t *self, byte command, int argc, byte *argv) { void ami_poll(sfx_softseq_t *self, byte *dest, int len) { int i, j; int16 *buf = (int16 *) dest; + // FIXME: memleak int16 *buffers = (int16*)malloc(len * 2 * CHANNELS_NR); memset(buffers, 0, len * 2 * CHANNELS_NR); -- cgit v1.2.3